[PR #4909] [MERGED] Implement Hard Reset for Terminal #26022

Open
opened 2026-01-31 09:13:26 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4909
Author: @zadjii-msft
Created: 3/13/2020
Status: Merged
Merged: 3/16/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/2715-part-2-RIS


📝 Commits (4)

  • 52124c7 Implement Hard Reset for Terminal
  • ae82bcb Apply suggestions from code review
  • fbf503b Merge remote-tracking branch 'origin/master' into dev/migrie/b/2715-part-2-RIS
  • 1006735 Fix merge with master

📊 Changes

5 files changed (+187 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalCore/TerminalDispatch.cpp (+98 -0)
📝 src/cascadia/TerminalCore/TerminalDispatch.hpp (+3 -0)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+71 -2)
📝 src/terminal/adapter/adaptDispatch.cpp (+8 -2)
📝 src/terminal/parser/OutputStateMachineEngine.cpp (+7 -0)

📄 Description

Summary of the Pull Request

This actually implements \033c
(RIS) for the Windows Terminal.
I thought I had done this in #4433, but that PR actually only passthrough'd
\x1b[3J. I didn't realize at the time that #2715 was mostly about hard reset,
not erase scrollback.

Not only should conpty pass through RIS, but the Terminal should also be
prepared to actually handle that sequence. So this PR adds that support as well.

References

  • #4433: original PR I thought fixed this.

PR Checklist

  • Closes #2715 for real this time
  • I work here
  • Tests added/passed
  • [n/a] Requires documentation to be updated

Validation Steps Performed

Actually tested printf \033c in the Terminal this time


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4909 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/16/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/2715-part-2-RIS` --- ### 📝 Commits (4) - [`52124c7`](https://github.com/microsoft/terminal/commit/52124c7835eeaf16b60544c42aa640d238ef2a9c) Implement Hard Reset for Terminal - [`ae82bcb`](https://github.com/microsoft/terminal/commit/ae82bcb5cdc8156dfb5516b7dc273396545fd600) Apply suggestions from code review - [`fbf503b`](https://github.com/microsoft/terminal/commit/fbf503b6dcf0dd750d4570e9ac0bc07c0c3c0726) Merge remote-tracking branch 'origin/master' into dev/migrie/b/2715-part-2-RIS - [`1006735`](https://github.com/microsoft/terminal/commit/10067352da849681fa2d4c0a48339340f25c5d88) Fix merge with master ### 📊 Changes **5 files changed** (+187 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/TerminalDispatch.cpp` (+98 -0) 📝 `src/cascadia/TerminalCore/TerminalDispatch.hpp` (+3 -0) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+71 -2) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+8 -2) 📝 `src/terminal/parser/OutputStateMachineEngine.cpp` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request This _actually_ implements `\033c` ([RIS](https://vt100.net/docs/vt220-rm/chapter4.html)) for the Windows Terminal. I thought I had done this in #4433, but that PR actually only passthrough'd `\x1b[3J`. I didn't realize at the time that #2715 was mostly about hard reset, not erase scrollback. Not only should conpty pass through RIS, but the Terminal should also be prepared to actually handle that sequence. So this PR adds that support as well. ## References * #4433: original PR I thought fixed this. ## PR Checklist * [x] Closes #2715 for real this time * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Actually tested `printf \033c` in the Terminal this time --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:26 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26022