starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Codebase invokes lots of undefined behavior by using reserved identifiers #4909

New Issue
Closed
opened 2026-01-30 23:59:58 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 23:59:58 +00:00
Owner
Copy Link

Originally created by @Longhanks on GitHub (Nov 10, 2019).

The code base seems to use lots of identifiers for private member objects or functions that start with an underscore, followed by an uppercase letter, such as IslandWindow::_ApplyWindowSize (/src/cascadia/WindowsTerminal/IslandWindow.h#L99).

The C++ standard however says:

In addition, some identifiers are reserved for use by C++ implementations and shall not be used otherwise; no diagnostic is required. Each identifier that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use.

(From https://eel.is/c++draft/lex.name#3.1)

Using such identifiers is technically an invocation of undefined behavior.

Originally created by @Longhanks on GitHub (Nov 10, 2019). The code base seems to use lots of identifiers for private member objects or functions that start with an underscore, followed by an uppercase letter, such as `IslandWindow::_ApplyWindowSize` ([/src/cascadia/WindowsTerminal/IslandWindow.h#L99](https://github.com/microsoft/terminal/blob/db797580923472c08613f054364097be06d73229/src/cascadia/WindowsTerminal/IslandWindow.h#L99)). The C++ standard however says: > In addition, some identifiers are reserved for use by C++ implementations and shall not be used otherwise; no diagnostic is required. Each identifier that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use. (From https://eel.is/c++draft/lex.name#3.1) Using such identifiers is technically an invocation of undefined behavior.
claunia commented 2026-01-30 23:59:59 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Nov 11, 2019):

Yeah.... someone on our team brought this up once but we determined it wasn't a big enough deal to spend time on at the moment. If you or anyone else is interested in fixing all the names to be compliant with the standard (and hopefully also write a test or something to enforce that we don't violate it again), we'd be happy to take it.

@miniksa commented on GitHub (Nov 11, 2019): Yeah.... someone on our team brought this up once but we determined it wasn't a big enough deal to spend time on at the moment. If you or anyone else is interested in fixing all the names to be compliant with the standard (and hopefully also write a test or something to enforce that we don't violate it again), we'd be happy to take it.
claunia commented 2026-01-30 23:59:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 19, 2019):

Oh my goodness this is actually already tracked in /dup #721

@zadjii-msft commented on GitHub (Dec 19, 2019): Oh my goodness this is actually already tracked in /dup #721
claunia commented 2026-01-30 23:59:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 19, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Dec 19, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?