starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Clean up the boundary between TerminalPage and TerminalApp #2647

New Issue
Open
opened 2026-01-30 23:01:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 23:01:10 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Jul 8, 2019).

Originally assigned to: @KaiyuWang16 on GitHub.

Right now, a lot of the logic for creating and maintaining a number of terminals lives in the TerminalApp::App singleton. That's not exactly correct by "xaml application" standards (nor is it correct by normal application standards.)

Pull request #XXX introduced a new xaml page that hosts the UI for the terminal. It should be tasked with maintaining the state of a number of terminal controls and connections so that ti becomes a reusable component. This may even be a step on the path to having multiple top-level windows hosting terminals -- if App can be the singleton in charge of settings and profile management, and a window can host a page instead of an App, we're in a better position to spawn more than one. 😄

thing currently should move
settings app -
settings reload app -
global error dialogs app ? not sure how this works in a multi-window world
ETW global registration app -
tab management app page
tab icons app page
clipboard management app ?
ETW tab logging app page
key bindings app page
Originally created by @DHowett-MSFT on GitHub (Jul 8, 2019). Originally assigned to: @KaiyuWang16 on GitHub. Right now, a lot of the logic for creating and maintaining a number of terminals lives in the `TerminalApp::App` singleton. That's not exactly _correct_ by "xaml application" standards (nor is it correct by normal application standards.) Pull request #XXX introduced a new xaml page that hosts the UI for the terminal. It should be tasked with maintaining the state of a number of terminal controls and connections so that ti becomes a reusable component. This may even be a step on the path to having multiple top-level windows hosting terminals -- if App can be the singleton in charge of settings and profile management, and a window can host a _page_ instead of an App, we're in a better position to spawn more than one. :smile: |thing|currently|should move| |-|-|-| |settings|app|-| |settings reload|app|-| |global error dialogs|app|? not sure how this works in a multi-window world| |ETW global registration|app|-| |tab management|app|page| |tab icons|app|page| |clipboard management|app|?| |ETW tab logging|app|page| |key bindings|app|page|
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2647
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?