starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5931] [MERGED] Replace manual get/set code in GlobalAppSettings with GETSET_PROPERTY #26544

New Issue
Open
opened 2026-01-31 09:16:43 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:43 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5931
Author: @DHowett-MSFT
Created: 5/15/2020
Status: ✅ Merged
Merged: 6/3/2020
Merged by: @undefined

Base: master ← Head: dev/duhowett/settings-2

📝 Commits (10+)

  • df88637 GlobalAppSettings: Convert to GETSET_PROPERTY
  • 561328f Convert the rest
  • 207dde3 GAS: DebugFeaturesEnabled (push down to settings-2)
  • 48703a5 lol nice comma
  • b356e0e Merge remote-tracking branch 'origin/master' into dev/duhowett/settings-2
  • 5435c86 and fix the build
  • 14d3e75 Merge remote-tracking branch 'origin/master' into dev/duhowett/settings-2
  • d718bdc PR Feedback
  • a959557 yes spellbot
  • 67460a0 I guess make sure the tests compile

📊 Changes

7 files changed (+121 additions, -305 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+16 -16)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+15 -22)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+5 -5)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+2 -2)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+42 -179)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+32 -72)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+9 -9)

📄 Description

Summary of the Pull Request

This pull request removes all of the custom Get and Set implementations from GlobalAppSettings and replaces them with GETSET_PROPERTY. This will be required if we ever convert it to a WinRT class, but for now it's simply niceness-improving.

References

Required #5847 to land.

PR Checklist

  • Closes norhing
  • CLAd
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5931 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 5/15/2020 **Status:** ✅ Merged **Merged:** 6/3/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/settings-2` --- ### 📝 Commits (10+) - [`df88637`](https://github.com/microsoft/terminal/commit/df88637531f0e8ebd84661206ce606c5e3ee7c17) GlobalAppSettings: Convert to GETSET_PROPERTY - [`561328f`](https://github.com/microsoft/terminal/commit/561328f77d6f607df76af98d79067e3707ca4b50) Convert the rest - [`207dde3`](https://github.com/microsoft/terminal/commit/207dde3b2c48ee16c29a0bf2abc7fc0859f921f2) GAS: DebugFeaturesEnabled (push down to settings-2) - [`48703a5`](https://github.com/microsoft/terminal/commit/48703a5d98787dc8a3ecf287c11ac01c98f5931e) lol nice comma - [`b356e0e`](https://github.com/microsoft/terminal/commit/b356e0e9449d122329a15c5b591338c17f5b8d73) Merge remote-tracking branch 'origin/master' into dev/duhowett/settings-2 - [`5435c86`](https://github.com/microsoft/terminal/commit/5435c86e8d853ed359aebbd3f6517e8b2e966df9) and fix the build - [`14d3e75`](https://github.com/microsoft/terminal/commit/14d3e7558d2065f4cf66ed3b3cef149c0b72a730) Merge remote-tracking branch 'origin/master' into dev/duhowett/settings-2 - [`d718bdc`](https://github.com/microsoft/terminal/commit/d718bdca26b492d5691753c85f22be9723758280) PR Feedback - [`a959557`](https://github.com/microsoft/terminal/commit/a95955769a123a73fe081ced22624d630ffb2e7a) yes spellbot - [`67460a0`](https://github.com/microsoft/terminal/commit/67460a0029ca070001e5b0bd755cc0bb5ec24027) I guess make sure the tests _compile_ ### 📊 Changes **7 files changed** (+121 additions, -305 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+16 -16) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+15 -22) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+5 -5) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+42 -179) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+32 -72) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+9 -9) </details> ### 📄 Description ## Summary of the Pull Request This pull request removes all of the custom `Get` and `Set` implementations from GlobalAppSettings and replaces them with `GETSET_PROPERTY`. This will be required if we ever convert it to a WinRT class, but for now it's simply niceness-improving. ## References Required #5847 to land. ## PR Checklist * [ ] Closes norhing * [x] CLAd * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:43 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?