We're not sizing the drag handle correctly all the time; it cuts off parts of the window sometimes #5847

Closed
opened 2026-01-31 00:23:16 +00:00 by claunia · 2 comments
Owner

Originally created by @burhan on GitHub (Jan 9, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows Version: 10.0.19041.0 ("slow ring" is enabled)

image

Terminal Version (0.7.3451.0); from the Windows Store

image

Native resolution: 2560 x 1440 (14" Lenovo X1 Carbon); scaling set at 125% (changed from 150% during this issue).

Steps to reproduce

Change the scaling ratio on your screen.

Expected behavior

Terminal window scales / adjusts automatically (which happens), but the controls for minimizing / maximizing disappear.

Honestly, not sure what is the expected behavior as many apps don't adjust properly, but after opening a new window, existing window at random starts showing the controls is why I raised this issue.

Actual behavior

(two instances I had open, when I changed the scaling ratio)

image

After opening a new window, randomly, the first window starts showing the minimize/maximize controls.

image

Originally created by @burhan on GitHub (Jan 9, 2020). Originally assigned to: @zadjii-msft on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Windows Version: 10.0.19041.0 ("slow ring" is enabled) ![image](https://user-images.githubusercontent.com/603112/72106066-c1775180-333f-11ea-94a8-6b3341278541.png) Terminal Version (0.7.3451.0); from the Windows Store ![image](https://user-images.githubusercontent.com/603112/72106171-e966b500-333f-11ea-925b-5a1df34c1899.png) Native resolution: 2560 x 1440 (14" Lenovo X1 Carbon); scaling set at 125% (changed from 150% during this issue). # Steps to reproduce Change the scaling ratio on your screen. # Expected behavior Terminal window scales / adjusts automatically (which happens), but the controls for minimizing / maximizing disappear. _Honestly, not sure what is the expected behavior as many apps don't adjust properly, but after opening a new window, existing window at random starts showing the controls is why I raised this issue._ <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior (two instances I had open, when I changed the scaling ratio) ![image](https://user-images.githubusercontent.com/603112/72105865-65143200-333f-11ea-8581-1d4aed137392.png) After opening a new window, randomly, the first window starts showing the minimize/maximize controls. ![image](https://user-images.githubusercontent.com/603112/72105987-9a208480-333f-11ea-8101-ffbdc3877430.png)
Author
Owner

@DHowett-MSFT commented on GitHub (Mar 2, 2020):

This is now the bug tracking the class of issues around drag bar sizing. Thanks!

@DHowett-MSFT commented on GitHub (Mar 2, 2020): This is now the bug tracking the class of issues around drag bar sizing. Thanks!
Author
Owner

@zadjii-msft commented on GitHub (Mar 6, 2020):

Getting the repro working exactly for me was a little tricky, but I think I got it. For me, the trick was that the window had to be in a spot where the cursor wouldn't be on top of the window immediately after the DPI scale changes. Expect a PR soon ☺️

@zadjii-msft commented on GitHub (Mar 6, 2020): Getting the repro working exactly for me was a little tricky, but I think I got it. For me, the trick was that the window had to be in a spot where the cursor wouldn't be on top of the window immediately after the DPI scale changes. Expect a PR soon ☺️
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5847