starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9096] [MERGED] Introduce DxFontRenderData #27421

New Issue
Open
opened 2026-01-31 09:21:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:21:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9096
Author: @skyline75489
Created: 2/10/2021
Status: ✅ Merged
Merged: 2/18/2021
Merged by: @undefined

Base: main ← Head: chesterliu/dev/font-render-data

📝 Commits (10+)

📊 Changes

10 files changed (+928 additions, -875 deletions)

View changed files

📝 src/renderer/base/lib/base.vcxproj (+1 -1)
📝 src/renderer/dx/CustomTextLayout.cpp (+23 -288)
📝 src/renderer/dx/CustomTextLayout.h (+4 -21)
➕ src/renderer/dx/DxFontRenderData.cpp (+755 -0)
➕ src/renderer/dx/DxFontRenderData.h (+96 -0)
📝 src/renderer/dx/DxRenderer.cpp (+41 -520)
📝 src/renderer/dx/DxRenderer.hpp (+3 -45)
📝 src/renderer/dx/lib/dx.vcxproj (+2 -0)
📝 src/renderer/dx/lib/dx.vcxproj.filters (+2 -0)
📝 src/renderer/dx/sources.inc (+1 -0)

📄 Description

This is my attempt to isolate all the dwrite font related thing by
introducing a new layer - DxFontRenderData. This will free
DxRenderer & CustomTextLayout from the burden of handling fonts &
box effects. The logic is more simplified & streamlined.

In short I just moved everything fonts-related into DxFontRenderData
and started from there. There's no modification to code logic. Just pure
structural stuff.

SGR support tracking issue: #6879
Initial Italic support PR: #8580

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9096 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 2/10/2021 **Status:** ✅ Merged **Merged:** 2/18/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `chesterliu/dev/font-render-data` --- ### 📝 Commits (10+) - [`bc6ab94`](https://github.com/microsoft/terminal/commit/bc6ab94f9d54415815864bba3e08029625e27580) Initialize IFontRenderData & DxFontRenderData - [`1440ae7`](https://github.com/microsoft/terminal/commit/1440ae7595f0693e605aecdb7ba9f80c590992a4) vcxprojc - [`ba43e8c`](https://github.com/microsoft/terminal/commit/ba43e8ccbddde172aaaa3656c46a757623fd6f58) Refactor - [`9a7413e`](https://github.com/microsoft/terminal/commit/9a7413e367d2e7f5f4f730393a7e26774111433e) Feedback - [`5b65094`](https://github.com/microsoft/terminal/commit/5b650941924b814fcb3b4e58d41d948d755a23ed) Format - [`c9a43be`](https://github.com/microsoft/terminal/commit/c9a43be7934ed1d3577c20725e6c1d199b884a9d) Unused - [`36e7463`](https://github.com/microsoft/terminal/commit/36e7463306fcc0ae5070b617122305375363fd1d) Feedback - [`d651886`](https://github.com/microsoft/terminal/commit/d65188616e9725320c8334905c3e5c4c67a4b819) Merge branch 'main' into chesterliu/dev/font-render-data - [`3a44c44`](https://github.com/microsoft/terminal/commit/3a44c44ce65bf166d583fd4423ba3d5408a4d482) Fix locale name - [`149951b`](https://github.com/microsoft/terminal/commit/149951b126e7ecb9f474a37b8105dbce9a6a2efb) Hide UserLocaleName ### 📊 Changes **10 files changed** (+928 additions, -875 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/base/lib/base.vcxproj` (+1 -1) 📝 `src/renderer/dx/CustomTextLayout.cpp` (+23 -288) 📝 `src/renderer/dx/CustomTextLayout.h` (+4 -21) ➕ `src/renderer/dx/DxFontRenderData.cpp` (+755 -0) ➕ `src/renderer/dx/DxFontRenderData.h` (+96 -0) 📝 `src/renderer/dx/DxRenderer.cpp` (+41 -520) 📝 `src/renderer/dx/DxRenderer.hpp` (+3 -45) 📝 `src/renderer/dx/lib/dx.vcxproj` (+2 -0) 📝 `src/renderer/dx/lib/dx.vcxproj.filters` (+2 -0) 📝 `src/renderer/dx/sources.inc` (+1 -0) </details> ### 📄 Description This is my attempt to isolate all the dwrite font related thing by introducing a new layer - `DxFontRenderData`. This will free `DxRenderer` & `CustomTextLayout` from the burden of handling fonts & box effects. The logic is more simplified & streamlined. In short I just moved everything fonts-related into `DxFontRenderData` and started from there. There's no modification to code logic. Just pure structural stuff. SGR support tracking issue: #6879 Initial Italic support PR: #8580 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?