[PR #9324] [MERGED] Change SettingsTab close icon to be smaller #27532

Open
opened 2026-01-31 09:22:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9324
Author: @carlos-zamora
Created: 3/2/2021
Status: ✅ Merged
Merged: 3/4/2021
Merged by: @undefined

Base: main ← Head: dev/cazamor/sui/settings-tab-close-icon


📝 Commits (1)

  • abe03d8 Change SettingsTab close icon to be smaller

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabBase.cpp (+1 -1)

📄 Description

We were using the wrong close icon for the settings tab. This is a side effect of TerminalTab overriding TabBase's implementation.

#6800 - Settings UI Epic

Closes #9317


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9324 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/2/2021 **Status:** ✅ Merged **Merged:** 3/4/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/sui/settings-tab-close-icon` --- ### 📝 Commits (1) - [`abe03d8`](https://github.com/microsoft/terminal/commit/abe03d83e689fce78099df0e174cdd7965aff2d7) Change SettingsTab close icon to be smaller ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabBase.cpp` (+1 -1) </details> ### 📄 Description We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation. #6800 - Settings UI Epic Closes #9317 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:32 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27532