starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9525] [MERGED] Shell Extension: Remove C++/WinRT authoring dependency #27609

New Issue
Open
opened 2026-01-31 09:23:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:23:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9525
Author: @DHowett
Created: 3/17/2021
Status: ✅ Merged
Merged: 3/17/2021
Merged by: @undefined

Base: main ← Head: dev/duhowett/shellext-why-cppwinrt

📝 Commits (3)

  • d7363c2 Shell Extension: Remove C++/WinRT authoring dependency
  • a188df8 Speelbot the fix
  • b2dfb1a And of course, we're not a winrt component anymore

📊 Changes

7 files changed (+52 additions, -96 deletions)

View changed files

📝 .github/actions/spelling/dictionary/apis.txt (+1 -0)
➖ src/cascadia/ShellExtension/PlaceholderType.cpp (+0 -10)
➖ src/cascadia/ShellExtension/PlaceholderType.h (+0 -37)
➖ src/cascadia/ShellExtension/PlaceholderType.idl (+0 -21)
📝 src/cascadia/ShellExtension/WindowsTerminalShellExt.def (+2 -2)
📝 src/cascadia/ShellExtension/WindowsTerminalShellExt.vcxproj (+36 -12)
📝 src/cascadia/ShellExtension/dllmain.cpp (+13 -14)

📄 Description

We don't need to use C++/WinRT's component authoring capabilities to be
a COM component. It's easier for us if we're not (and it makes the build
slightly faster!)

Binary size savings (x64 Release):

Note WindowsTerminalShellExt.dll
Before 136192
After 130048
Delta 6144
%Delta 4.5%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9525 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 3/17/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/shellext-why-cppwinrt` --- ### 📝 Commits (3) - [`d7363c2`](https://github.com/microsoft/terminal/commit/d7363c2e09601ef3e3e2898660da82e8b7e0c22b) Shell Extension: Remove C++/WinRT authoring dependency - [`a188df8`](https://github.com/microsoft/terminal/commit/a188df8f35c0745d9e923d92490a969561f731bc) Speelbot the fix - [`b2dfb1a`](https://github.com/microsoft/terminal/commit/b2dfb1af19784a08f0d92a56bd1f1be627b6d753) And of course, we're not a winrt component anymore ### 📊 Changes **7 files changed** (+52 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/dictionary/apis.txt` (+1 -0) ➖ `src/cascadia/ShellExtension/PlaceholderType.cpp` (+0 -10) ➖ `src/cascadia/ShellExtension/PlaceholderType.h` (+0 -37) ➖ `src/cascadia/ShellExtension/PlaceholderType.idl` (+0 -21) 📝 `src/cascadia/ShellExtension/WindowsTerminalShellExt.def` (+2 -2) 📝 `src/cascadia/ShellExtension/WindowsTerminalShellExt.vcxproj` (+36 -12) 📝 `src/cascadia/ShellExtension/dllmain.cpp` (+13 -14) </details> ### 📄 Description We don't need to use C++/WinRT's component authoring capabilities to be a COM component. It's easier for us if we're not (and it makes the build slightly faster!) Binary size savings (x64 Release): Note | WindowsTerminalShellExt.dll ------ | --------------------------- Before | 136192 After | 130048 Delta | 6144 %Delta | 4.5% --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?