starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12674] [MERGED] Update .NET from unsupported 4.5 to 4.8 to silence VS2022 #29172

New Issue
Open
opened 2026-01-31 09:33:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:33:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12674
Author: @dmachaj
Created: 3/11/2022
Status: ✅ Merged
Merged: 3/14/2022
Merged by: @undefined

Base: main ← Head: user/dmachaj/fix-dotnet-error

📝 Commits (2)

  • c0322d7 Update .net framework from unsupported 4.5 to 4.8 to silence VS2022 errors when opening solution
  • ba35f23 defuse the BOM

📊 Changes

6 files changed (+34 additions, -8 deletions)

View changed files

📝 src/cascadia/WindowsTerminal_UIATests/WindowsTerminal.UIA.Tests.csproj (+2 -1)
📝 src/cascadia/WindowsTerminal_UIATests/app.config (+4 -1)
📝 src/host/ft_uia/Host.Tests.UIA.csproj (+2 -1)
📝 src/host/ft_uia/app.config (+4 -1)
📝 src/tools/vtapp/App.config (+1 -1)
📝 src/tools/vtapp/VTApp.csproj (+21 -3)

📄 Description

Summary of the Pull Request

Closes #12670
Visual Studio 2022 offered to upgrade .NET Framework from an unsupported 4.5 to a supported 4.8. I let it do its thing (and undid a number of whitespace-only changes that aren't necessary). The project still builds after this. The UIA tests fail to run but I think that is preexisting and will be filing a new issue momentarily.

PR Checklist

Validation Steps Performed

The solution compiles in VS2022 (except for #12673).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12674 **Author:** [@dmachaj](https://github.com/dmachaj) **Created:** 3/11/2022 **Status:** ✅ Merged **Merged:** 3/14/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `user/dmachaj/fix-dotnet-error` --- ### 📝 Commits (2) - [`c0322d7`](https://github.com/microsoft/terminal/commit/c0322d71250bd3e5b5c754f4396b47d5d5bb7c17) Update .net framework from unsupported 4.5 to 4.8 to silence VS2022 errors when opening solution - [`ba35f23`](https://github.com/microsoft/terminal/commit/ba35f23274dbd4ba85793f18afca6a143706c934) defuse the BOM ### 📊 Changes **6 files changed** (+34 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal_UIATests/WindowsTerminal.UIA.Tests.csproj` (+2 -1) 📝 `src/cascadia/WindowsTerminal_UIATests/app.config` (+4 -1) 📝 `src/host/ft_uia/Host.Tests.UIA.csproj` (+2 -1) 📝 `src/host/ft_uia/app.config` (+4 -1) 📝 `src/tools/vtapp/App.config` (+1 -1) 📝 `src/tools/vtapp/VTApp.csproj` (+21 -3) </details> ### 📄 Description ## Summary of the Pull Request Closes #12670 Visual Studio 2022 offered to upgrade .NET Framework from an unsupported 4.5 to a supported 4.8. I let it do its thing (and undid a number of whitespace-only changes that aren't necessary). The project still builds after this. The UIA tests fail to run but I think that is preexisting and will be filing a new issue momentarily. ## PR Checklist * [x] Closes #12670 * [x] Tests added/passed ## Validation Steps Performed The solution compiles in VS2022 (except for #12673). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?