starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12893] [MERGED] Add experimental setting to make bg images fit the whole tab #29280

New Issue
Open
opened 2026-01-31 09:33:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:33:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12893
Author: @nico-abram
Created: 4/12/2022
Status: ✅ Merged
Merged: 4/27/2022
Merged by: @undefined

Base: main ← Head: uwu

📝 Commits (4)

  • be1cacf Add experimental setting to make bg images fit the whole tab
  • 6c4e58d Formatting
  • f5d6b1a Apply requested review changes
  • c3b165f Rename BgImageForWindow to UseBackgroundImageForWindow

📊 Changes

14 files changed (+120 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabManagement.cpp (+18 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+63 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+5 -1)
📝 src/cascadia/TerminalApp/pch.h (+1 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -1)
📝 src/cascadia/TerminalControl/IControlSettings.idl (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+23 -5)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -0)
📝 src/cascadia/inc/ControlProperties.h (+1 -0)

📄 Description

Summary of the Pull Request

Fixes #6028
Setting is "experimental.useBackgroundImageForWindow"

References

https://github.com/microsoft/terminal/issues/6028

PR Checklist

Validation Steps Performed

Set "experimental.useBackgroundImageForWindow": true and a bg image for one profile, then make splits and tabs and make sure the bg updates accordingly:
xqMUWpo1JK
I also did the same with the setting off to make sure it still works correctly and didn't break. And I made sure opening the settings tab does not crash or show the bg image.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12893 **Author:** [@nico-abram](https://github.com/nico-abram) **Created:** 4/12/2022 **Status:** ✅ Merged **Merged:** 4/27/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `uwu` --- ### 📝 Commits (4) - [`be1cacf`](https://github.com/microsoft/terminal/commit/be1cacf4d10fdf4060528da119842485739d9292) Add experimental setting to make bg images fit the whole tab - [`6c4e58d`](https://github.com/microsoft/terminal/commit/6c4e58d9c0dedd1ffe98f94d47c393156997b9b2) Formatting - [`f5d6b1a`](https://github.com/microsoft/terminal/commit/f5d6b1a61611a087de521ee7a859177c5b5e0ea9) Apply requested review changes - [`c3b165f`](https://github.com/microsoft/terminal/commit/c3b165fb33bf2723a4ff5698fee3eb0ff7999b30) Rename BgImageForWindow to UseBackgroundImageForWindow ### 📊 Changes **14 files changed** (+120 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+18 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+63 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+5 -1) 📝 `src/cascadia/TerminalApp/pch.h` (+1 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/IControlSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+23 -5) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -0) 📝 `src/cascadia/inc/ControlProperties.h` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Fixes #6028 Setting is "experimental.useBackgroundImageForWindow" <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References https://github.com/microsoft/terminal/issues/6028 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #6028 * [X] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. I read CONTRIBUTING.md, but I'm not sure if a spec is needed for an experimental feature such as this one. * [ ] Schema updated. I added a JSON key, not sure where I need to update it. * [X] I've discussed this with core contributors already. Somewhat discussed in https://github.com/microsoft/terminal/issues/6028 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here ## Detailed Description of the Pull Request / Additional comments --> <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Set ` "experimental.useBackgroundImageForWindow": true` and a bg image for one profile, then make splits and tabs and make sure the bg updates accordingly: ![xqMUWpo1JK](https://user-images.githubusercontent.com/24706838/162996037-ce2ec077-d0e8-43ab-ad5b-0e5c0354fc30.gif) I also did the same with the setting off to make sure it still works correctly and didn't break. And I made sure opening the settings tab does not crash or show the bg image. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?