starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Maximize and minimize window buttons incorrect rendering #6028

New Issue
Closed
opened 2026-01-31 00:28:05 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 00:28:05 +00:00
Owner
Copy Link

Originally created by @JekRock on GitHub (Jan 18, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable):0.8.10091.0

Steps to reproduce

  1. Minimize the Windows Terminal window
  2. Open enough terminal tabs to fill tabs space without tabs being resized.
  3. Maximize the Windows Terminal window with the window maximize button.
  4. Minimize the Windows Terminal window with the window minimize button.
  5. Get an incorrect rendering of the minimize and maximize buttons.

On step 2 you will probably need to play with the Windows Terminal window size to reproduce the issue. For some window sizes, it renders normally and for some not. If you add too many terminal tabs the issue is not reproducible.

Expected behavior

Normal rendering of the window minimize and maximize buttons after minimizing the Windows Terminal window

Actual behavior

See attached screenshots.
image
image
image

Originally created by @JekRock on GitHub (Jan 18, 2020). Originally assigned to: @zadjii-msft on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable):0.8.10091.0 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Minimize the Windows Terminal window 2. Open enough terminal tabs to fill tabs space without tabs being resized. 3. Maximize the Windows Terminal window with the window maximize button. 4. Minimize the Windows Terminal window with the window minimize button. 5. Get an incorrect rendering of the minimize and maximize buttons. On step 2 you will probably need to play with the Windows Terminal window size to reproduce the issue. For some window sizes, it renders normally and for some not. If you add too many terminal tabs the issue is not reproducible. # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> Normal rendering of the window minimize and maximize buttons after minimizing the Windows Terminal window # Actual behavior <!-- What's actually happening? --> See attached screenshots. ![image](https://user-images.githubusercontent.com/5882133/72663459-b2f1ff80-39fb-11ea-9dcf-2bc9a423e47f.png) ![image](https://user-images.githubusercontent.com/5882133/72663470-c9985680-39fb-11ea-883a-5c781926e60a.png) ![image](https://user-images.githubusercontent.com/5882133/72663479-d9179f80-39fb-11ea-8504-c83ad35e4878.png)
claunia commented 2026-01-31 00:28:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 21, 2020):

from #4310:

@DHowett-MSFT

What is your display scaling set to?

@JekRock

I've stumbled upon the same issue. It's described here
I have 2 displays. One with 100% scaling and one with 125%. The issue is reproducible on both displays

@zadjii-msft commented on GitHub (Jan 21, 2020): _from #4310_: @DHowett-MSFT > What is your display scaling set to? @JekRock > I've stumbled upon the same issue. It's described [here](https://github.com/microsoft/terminal/issues/4288) > I have 2 displays. One with 100% scaling and one with 125%. The issue is reproducible on both displays
claunia commented 2026-01-31 00:28:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 23, 2020):

It looks like we're not placing the drag cutout in the right place. Might be part of #1625.

@DHowett-MSFT commented on GitHub (Jan 23, 2020): It looks like we're not placing the drag cutout in the right place. Might be part of #1625.
claunia commented 2026-01-31 00:28:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 23, 2020):

v0.10 justification: it's experience-breaking.

@DHowett-MSFT commented on GitHub (Jan 23, 2020): v0.10 justification: it's experience-breaking.
claunia commented 2026-01-31 00:28:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 2, 2020):

I'm going to call this a "bug class" and merge it with /dup #4166 - "we are not sizing the drag bar properly all the time"

@DHowett-MSFT commented on GitHub (Mar 2, 2020): I'm going to call this a "bug class" and merge it with /dup #4166 - "we are not sizing the drag bar properly all the time"
claunia commented 2026-01-31 00:28:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 2, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Mar 2, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:28:08 +00:00
Author
Owner
Copy Link

@beviu commented on GitHub (Mar 6, 2020):

@zadjii-msft

This was marked duplicate of #4166 and #4166 was closed but I can still reproduce this bug on master (cc35c83e) with your fix on my 100% dpi displays so I think it's a separate issue (maybe it was not a dup and it has nothing to do with DPI!).

steps:
test

  1. launch terminal, keep its original size (but note that my config has 0 padding, see below)
  2. resize it to remove one text column
  3. add 4 tabs
  4. maximize
  5. minimize
  6. try to hover min/max controls
my config 


// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation

{
    "$schema": "https://aka.ms/terminal-profiles-schema",

    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

    "profiles":
    [
        {
            // Make changes here to the powershell.exe profile
            "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
            "name": "Windows PowerShell",
            "commandline": "powershell.exe",
            "hidden": false,
            "padding": "0"
        },
        {
            // Make changes here to the cmd.exe profile
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "cmd",
            "commandline": "cmd.exe",
            "hidden": false,
            "padding": "0"
        }
    ],

    // Add custom color schemes to this array
    "schemes": [],

    // Add any keybinding overrides to this array.
    // To unbind a default keybinding, set the command to "unbound"
    "keybindings": [],

    "showTabsInTitlebar": true
}

(On the GIF i was actually running my branch to get rid of HRGN so that's why the controls didn't completely disappear like in the image from the issue but you can ignore this)

@beviu commented on GitHub (Mar 6, 2020): @zadjii-msft This was marked duplicate of #4166 and #4166 was closed but I can still reproduce this bug on master (cc35c83e) with your fix on my 100% dpi displays so I think it's a separate issue (maybe it was not a dup and it has nothing to do with DPI!). steps: ![test](https://user-images.githubusercontent.com/56923875/76131079-609d8a00-600d-11ea-93d8-a46d44868b4e.gif) 1. launch terminal, keep its original size (but note that my config has 0 padding, see below) 2. resize it to remove one text column 3. add 4 tabs 4. maximize 5. minimize 6. try to hover min/max controls <details><summary>my config</summary> <p> ```jsonc // To view the default settings, hold "alt" while clicking on the "Settings" button. // For documentation on these settings, see: https://aka.ms/terminal-documentation { "$schema": "https://aka.ms/terminal-profiles-schema", "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "profiles": [ { // Make changes here to the powershell.exe profile "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "name": "Windows PowerShell", "commandline": "powershell.exe", "hidden": false, "padding": "0" }, { // Make changes here to the cmd.exe profile "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "name": "cmd", "commandline": "cmd.exe", "hidden": false, "padding": "0" } ], // Add custom color schemes to this array "schemes": [], // Add any keybinding overrides to this array. // To unbind a default keybinding, set the command to "unbound" "keybindings": [], "showTabsInTitlebar": true } ``` </p> </details> (On the GIF i was actually running my branch to get rid of HRGN so that's why the controls didn't completely disappear like in the image from the issue but you can ignore this)
claunia commented 2026-01-31 00:28:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 9, 2020):

Okay yea I can re-activate this one and make sure this gets fixed too.

Thanks for the diligence @greg904!

EDIT: Wow I got this to happen immediately. My repro was way easier:
<notes to self>

  1. Use the "mode" profile I currently have as default, and "initialCols": 80. The "mode" bit probably isn't relevant.
  2. Open a second tab
  3. Maximize
  4. Restore

and that's it.

@zadjii-msft commented on GitHub (Mar 9, 2020): Okay yea I can re-activate this one and make sure this gets fixed too. Thanks for the diligence @greg904! <hr> EDIT: Wow I got this to happen immediately. My repro was way easier: \<notes to self> 1. Use the "mode" profile I currently have as default, and `"initialCols": 80`. The "mode" bit probably isn't relevant. 2. Open a second tab 3. Maximize 4. Restore and that's it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6028
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?