starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13516] [CLOSED] Make selection have an exclusive end #29597

New Issue
Open
opened 2026-01-31 09:35:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13516
Author: @carlos-zamora
Created: 7/15/2022
Status: ❌ Closed

Base: main ← Head: dev/cazamor/sln/exclusive-end

📝 Commits (2)

  • 760064d rendering + markers + KS + mouse
  • a284281 Migrate spelling-0.0.21 changes from main

📊 Changes

19 files changed (+1199 additions, -901 deletions)

View changed files

➕ .github/actions/spelling/README.md (+15 -0)
📝 .github/actions/spelling/advice.md (+16 -18)
📝 .github/actions/spelling/allow/allow.txt (+10 -2)
📝 .github/actions/spelling/allow/apis.txt (+15 -3)
📝 .github/actions/spelling/allow/names.txt (+2 -0)
➕ .github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+39 -6)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -8)
📝 .github/actions/spelling/expect/expect.txt (+127 -755)
📝 .github/actions/spelling/expect/web.txt (+0 -23)
➕ .github/actions/spelling/line_forbidden.patterns (+62 -0)
📝 .github/actions/spelling/patterns/patterns.txt (+73 -0)
📝 .github/actions/spelling/reject.txt (+9 -19)
📝 .github/workflows/spelling2.yml (+123 -9)
📝 src/buffer/out/textBuffer.cpp (+18 -4)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+4 -3)
📝 src/cascadia/TerminalControl/TermControl.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+5 -4)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+157 -46)

📄 Description

Summary of the Pull Request

Selection is generally stored as a range of start and end where start <= end. However, this prevents the ability to have a selection be an empty range denoting the space between two cells. To fix this, we need to make the end exclusive.

References

Epic: #4993
Closes #13447

Detailed Description of the Pull Request / Additional comments

TODO CARLOS: I'll write this at some point, I swear.

Validation Steps Performed

  • Rendering the selection

  • Copying the selection

  • Selection markers

  • Keyboard Selection

mode left right up down
char cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
word cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
view cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
buffer cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
  • Mouse selection
# of clicks no movement click + drag shift + click
1 ✅ ✅ ✅
2 ✅ ❓ ✅
3 ✅ ❓ ✅

  • Block selection

    • alt + drag mouse
    • keyboard selection

  • Corner cases:

    • wide glyphs
    • scrolling when keyboard selection goes to the top/bottom edge
    • click +drag to the left/right edge
    • keyboard selection when wrapping off the left/right edge

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13516 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 7/15/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/cazamor/sln/exclusive-end` --- ### 📝 Commits (2) - [`760064d`](https://github.com/microsoft/terminal/commit/760064d0fb71a29b3a0b2b3502366883051b87e2) rendering + markers + KS + mouse - [`a284281`](https://github.com/microsoft/terminal/commit/a284281d87a555664cedd4f91b57d7a36b40d11b) Migrate spelling-0.0.21 changes from main ### 📊 Changes **19 files changed** (+1199 additions, -901 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spelling/README.md` (+15 -0) 📝 `.github/actions/spelling/advice.md` (+16 -18) 📝 `.github/actions/spelling/allow/allow.txt` (+10 -2) 📝 `.github/actions/spelling/allow/apis.txt` (+15 -3) 📝 `.github/actions/spelling/allow/names.txt` (+2 -0) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+39 -6) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -8) 📝 `.github/actions/spelling/expect/expect.txt` (+127 -755) 📝 `.github/actions/spelling/expect/web.txt` (+0 -23) ➕ `.github/actions/spelling/line_forbidden.patterns` (+62 -0) 📝 `.github/actions/spelling/patterns/patterns.txt` (+73 -0) 📝 `.github/actions/spelling/reject.txt` (+9 -19) 📝 `.github/workflows/spelling2.yml` (+123 -9) 📝 `src/buffer/out/textBuffer.cpp` (+18 -4) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+4 -3) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+5 -4) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+157 -46) </details> ### 📄 Description ## Summary of the Pull Request Selection is generally stored as a range of `start` and `end` where `start <= end`. However, this prevents the ability to have a selection be an empty range denoting the space between two cells. To fix this, we need to make the `end` exclusive. ## References Epic: #4993 Closes #13447 ## Detailed Description of the Pull Request / Additional comments TODO CARLOS: I'll write this at some point, I swear. ## Validation Steps Performed - [X] Rendering the selection - [X] Copying the selection - [X] Selection markers - Keyboard Selection | mode | left | right | up | down | |--|--|--|--|--| | char | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | word | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | view | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | buffer | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | - Mouse selection | # of clicks | no movement | click + drag | shift + click | |--|--|--|--| | 1 | ✅ | ✅ | ✅ | | 2 | ✅ | ❓ | ✅ | | 3 | ✅ | ❓ | ✅ | - Block selection - [X] alt + drag mouse - [X] keyboard selection - Corner cases: - [ ] wide glyphs - [ ] scrolling when keyboard selection goes to the top/bottom edge - [ ] click +drag to the left/right edge - [X] keyboard selection when wrapping off the left/right edge --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?