starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

CLS should reset the virtual viewport bottom #13516

New Issue
Closed
opened 2026-01-31 03:44:45 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 03:44:45 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Apr 17, 2021).

Windows Terminal version (or Windows build number)

74909c0c65

Other Software

No response

Steps to reproduce

  1. Make sure you're using a build with PR #9770 merged.
  2. Open a conhost cmd shell.
  3. Output some content to fill a few pages of the buffer.
  4. Execute cls.

Expected Behavior

The buffer should be cleared and the viewport should be moved back to the top of the buffer.

Actual Behavior

The buffer is cleared, but the viewport remains where it was before the cls.

I'm afraid I broke this with PR #9770. Previously cls would have reset the virtual bottom when it reset the viewport, but it doesn't do that anymore. And I suspect there are probably more cases like this.

I'm really not sure what the right solution is though - maybe every viewport change made through the console API should reset the virtual bottom? But whatever we do, there are going to be some cases that behave weirdly - I think that's inevitable when you're mixing the legacy APIs with VT.

For now, though, I think it might be a good idea to revert #9770, because this bug seems a lot worse than #9754.

Originally created by @j4james on GitHub (Apr 17, 2021). ### Windows Terminal version (or Windows build number) 74909c0c6511787907a6a369c8046c11ee373ae8 ### Other Software _No response_ ### Steps to reproduce 1. Make sure you're using a build with PR #9770 merged. 2. Open a conhost cmd shell. 3. Output some content to fill a few pages of the buffer. 4. Execute `cls`. ### Expected Behavior The buffer should be cleared and the viewport should be moved back to the top of the buffer. ### Actual Behavior The buffer is cleared, but the viewport remains where it was before the `cls`. I'm afraid I broke this with PR #9770. Previously `cls` would have reset the virtual bottom when it reset the viewport, but it doesn't do that anymore. And I suspect there are probably more cases like this. I'm really not sure what the right solution is though - maybe every viewport change made through the console API should reset the virtual bottom? But whatever we do, there are going to be some cases that behave weirdly - I think that's inevitable when you're mixing the legacy APIs with VT. For now, though, I think it might be a good idea to revert #9770, because this bug seems a lot worse than #9754.
claunia added the Product-ConhostNeeds-TriageArea-VTNeeds-Tag-Fix labels 2026-01-31 03:44:45 +00:00
claunia commented 2026-01-31 03:44:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 28, 2021):

For now, though, I think it might be a good idea to revert #9770, because this bug seems a lot worse than #9754.

Thanks for this. Sorry for the delay here -- we're getting to the end of a Windows dev cycle and by now you've probably guessed that that tends to eclipse the sun. 😄

I'll revert 9770 on main.

@DHowett commented on GitHub (Apr 28, 2021): > For now, though, I think it might be a good idea to revert #9770, because this bug seems a lot worse than #9754. Thanks for this. Sorry for the delay here -- we're getting to the end of a Windows dev cycle and by now you've probably guessed that that tends to eclipse the sun. :smile: I'll revert 9770 on main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Needs-Tag-Fix Needs-Triage Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?