starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13516] Make selection have an exclusive end #29602

New Issue
Open
opened 2026-01-31 09:35:51 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:51 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/13516

State: closed
Merged: No

Summary of the Pull Request

Selection is generally stored as a range of start and end where start <= end. However, this prevents the ability to have a selection be an empty range denoting the space between two cells. To fix this, we need to make the end exclusive.

References

Epic: #4993
Closes #13447

Detailed Description of the Pull Request / Additional comments

TODO CARLOS: I'll write this at some point, I swear.

Validation Steps Performed

  • Rendering the selection

  • Copying the selection

  • Selection markers

  • Keyboard Selection

mode left right up down
char cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
word cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
view cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
buffer cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅		 cursor: ✅
start: ✅
end: ✅
  • Mouse selection
# of clicks no movement click + drag shift + click
1 ✅ ✅ ✅
2 ✅ ❓ ✅
3 ✅ ❓ ✅

  • Block selection

    • alt + drag mouse
    • keyboard selection

  • Corner cases:

    • wide glyphs
    • scrolling when keyboard selection goes to the top/bottom edge
    • click +drag to the left/right edge
    • keyboard selection when wrapping off the left/right edge
**Original Pull Request:** https://github.com/microsoft/terminal/pull/13516 **State:** closed **Merged:** No --- ## Summary of the Pull Request Selection is generally stored as a range of `start` and `end` where `start <= end`. However, this prevents the ability to have a selection be an empty range denoting the space between two cells. To fix this, we need to make the `end` exclusive. ## References Epic: #4993 Closes #13447 ## Detailed Description of the Pull Request / Additional comments TODO CARLOS: I'll write this at some point, I swear. ## Validation Steps Performed - [X] Rendering the selection - [X] Copying the selection - [X] Selection markers - Keyboard Selection | mode | left | right | up | down | |--|--|--|--|--| | char | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | word | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | view | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | | buffer | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | cursor: ✅ <br/> start: ✅ <br/> end: ✅ | - Mouse selection | # of clicks | no movement | click + drag | shift + click | |--|--|--|--| | 1 | ✅ | ✅ | ✅ | | 2 | ✅ | ❓ | ✅ | | 3 | ✅ | ❓ | ✅ | - Block selection - [X] alt + drag mouse - [X] keyboard selection - Corner cases: - [ ] wide glyphs - [ ] scrolling when keyboard selection goes to the top/bottom edge - [ ] click +drag to the left/right edge - [X] keyboard selection when wrapping off the left/right edge
claunia added the pull-request label 2026-01-31 09:35:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?