[PR #13661] [MERGED] Fix the ConPTY extended attributes optimization #29698

Open
opened 2026-01-31 09:36:23 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13661
Author: @zadjii-msft
Created: 8/2/2022
Status: Merged
Merged: 8/5/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/8341-but-also-maybe-13229


📝 Commits (10+)

  • e476682 HAX: Try to fix the conpty first frame boog
  • 9dcc2da this seems to work and pass tests. Needs to be cleaner, have more tests, and be more validated
  • 863c35a cleanup
  • 3748f52 Merge remote-tracking branch 'origin/main' into dev/migrie/b/8341-but-also-maybe-13229
  • f8ac846 Revert "HAX: Try to fix the conpty first frame boog"
  • e710300 spel
  • 433b168 tests
  • 824fa89 yea okay that's what tests are for
  • b02a8fe this wasn't even me (in this pr)
  • bfaa4d2 more tests MORE M O R E

📊 Changes

4 files changed (+121 additions, -7 deletions)

View changed files

📝 src/buffer/out/TextAttribute.cpp (+0 -5)
📝 src/buffer/out/TextAttribute.hpp (+11 -1)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+104 -0)
📝 src/renderer/vt/paint.cpp (+6 -1)

📄 Description

... which should have never worked in the first place

Quick filing a PR for review. This is the bulk of the actual code changes. Figured it was best to review the conpty changes sooner than later and I can add tests in the morning.

Test cases:

printf "\e[7m         test         \e[m\n"
printf "\e[7m"; printf ' %.0s' $(seq 1 $COLUMNS); printf "\e[m\n"

After:
image

Closes #13229

Definitely fixes:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13661 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/2/2022 **Status:** ✅ Merged **Merged:** 8/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/8341-but-also-maybe-13229` --- ### 📝 Commits (10+) - [`e476682`](https://github.com/microsoft/terminal/commit/e476682f2879c1b8b33bd40b5d4452d5861d2713) HAX: Try to fix the conpty first frame boog - [`9dcc2da`](https://github.com/microsoft/terminal/commit/9dcc2da2b62e33c98c510c47093ef9ac547447b2) this seems to work and pass tests. Needs to be cleaner, have more tests, and be more validated - [`863c35a`](https://github.com/microsoft/terminal/commit/863c35ab8e1b2dfa8a4b9062cd9a8271185c944f) cleanup - [`3748f52`](https://github.com/microsoft/terminal/commit/3748f52ffb47d0b5903966db92953d821e1c2a5a) Merge remote-tracking branch 'origin/main' into dev/migrie/b/8341-but-also-maybe-13229 - [`f8ac846`](https://github.com/microsoft/terminal/commit/f8ac846074411beaee8635fd96e45fb1c5f28753) Revert "HAX: Try to fix the conpty first frame boog" - [`e710300`](https://github.com/microsoft/terminal/commit/e710300b664ca8303b682c6c3e55e9766e6cb049) spel - [`433b168`](https://github.com/microsoft/terminal/commit/433b168b9a3a64067da07b96d6934aadf311482e) tests - [`824fa89`](https://github.com/microsoft/terminal/commit/824fa894566ca7e4f4772bf80136739c3ab9a99b) yea okay that's what tests are for - [`b02a8fe`](https://github.com/microsoft/terminal/commit/b02a8fe5014fdb78fb73ed86383510e2b99fc41a) this wasn't even me (in this pr) - [`bfaa4d2`](https://github.com/microsoft/terminal/commit/bfaa4d21d71da3415e723bd91536769d0cb8d11e) more tests MORE M O R E ### 📊 Changes **4 files changed** (+121 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/TextAttribute.cpp` (+0 -5) 📝 `src/buffer/out/TextAttribute.hpp` (+11 -1) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+104 -0) 📝 `src/renderer/vt/paint.cpp` (+6 -1) </details> ### 📄 Description ... which should have never worked in the first place Quick filing a PR for review. This is the bulk of the actual code changes. Figured it was best to review the conpty changes sooner than later and I can add tests in the morning. Test cases: ``` printf "\e[7m test \e[m\n" ``` ``` printf "\e[7m"; printf ' %.0s' $(seq 1 $COLUMNS); printf "\e[m\n" ``` After: ![image](https://user-images.githubusercontent.com/18356694/182478185-6e65ab99-5c27-4772-af3b-2baa22387ec1.png) Closes #13229 Definitely fixes: * [x] #13643 * [x] https://github.com/PowerShell/PowerShell/issues/17812 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:23 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29698