[PR #13744] [CLOSED] Add an UnhandledException handler at teardown #29739

Open
opened 2026-01-31 09:36:37 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13744
Author: @zadjii-msft
Created: 8/15/2022
Status: Closed

Base: mainHead: dev/migrie/b/12413-OnUnhandledException


📝 Commits (3)

  • 97d21b5 an experiment as mentioned by kmahoney
  • 4c06258 Merge remote-tracking branch 'origin/main' into dev/migrie/b/12413-OnUnhandledException
  • 144b3b3 comments

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/AppHost.cpp (+11 -0)

📄 Description

This is experimental, for sure. We've had a long battle of exceptions as the app gets closed. This should eat any XAML exceptions during teardown. It won't eat A/V's though.

I'm just throwing the PR out there. We can reject for all I care. We didn't end up needing it for the #12413 follow up.

<discuss>


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13744 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/15/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/migrie/b/12413-OnUnhandledException` --- ### 📝 Commits (3) - [`97d21b5`](https://github.com/microsoft/terminal/commit/97d21b5ef0af34feaf9803b3a13ba98d0db0aa59) an experiment as mentioned by kmahoney - [`4c06258`](https://github.com/microsoft/terminal/commit/4c062580a2be1b0350c872312e77ccfab1f79021) Merge remote-tracking branch 'origin/main' into dev/migrie/b/12413-OnUnhandledException - [`144b3b3`](https://github.com/microsoft/terminal/commit/144b3b39ff2cc2759bc5ad1cd67c969d6df020a2) comments ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+11 -0) </details> ### 📄 Description This is experimental, for sure. We've had a long battle of exceptions as the app gets closed. This should eat any XAML exceptions during teardown. It won't eat A/V's though. I'm just throwing the PR out there. We can reject for all I care. We didn't end up needing it for the #12413 follow up. \<discuss> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29739