[PR #14519] [MERGED] Match SearchBox AutoProp.Name to placeholder text #30125

Open
opened 2026-01-31 09:38:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14519
Author: @carlos-zamora
Created: 12/9/2022
Status: ✅ Merged
Merged: 12/13/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/a11y/find-auto-prop


📝 Commits (2)

  • 1c28f4e Match SearchBox AutoProp.Name to placeholder text
  • 806b92d remove code-behind change

📊 Changes

1 file changed (+31 additions, -31 deletions)

View changed files

📝 src/cascadia/TerminalControl/Resources/en-US/Resources.resw (+31 -31)

📄 Description

Voice Access allows for functionality like "click <name>" to automatically move the cursor and click on a control. The Search Box had an AutoProp.Name that didn't match the placeholder text, leading to confusion because Voice Access wouldn't be able to find a control named "Find...".

To fix this, we simply aligned the placeholder text and the AutoProp.Name to be "Find". The elipses were removed because no dialog is opened.

This fix was accomplished by modifying the resources file to explicitly match the AutoProp.Name to the placeholder text.

Closes #14398


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14519 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 12/9/2022 **Status:** ✅ Merged **Merged:** 12/13/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/a11y/find-auto-prop` --- ### 📝 Commits (2) - [`1c28f4e`](https://github.com/microsoft/terminal/commit/1c28f4e410e9e148d0fbc6ac54df66b583adad1b) Match SearchBox AutoProp.Name to placeholder text - [`806b92d`](https://github.com/microsoft/terminal/commit/806b92db98c61720ec5fe2c63049464376e99b32) remove code-behind change ### 📊 Changes **1 file changed** (+31 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/Resources/en-US/Resources.resw` (+31 -31) </details> ### 📄 Description Voice Access allows for functionality like "click \<name\>" to automatically move the cursor and click on a control. The Search Box had an AutoProp.Name that didn't match the placeholder text, leading to confusion because Voice Access wouldn't be able to find a control named "Find...". To fix this, we simply aligned the placeholder text and the AutoProp.Name to be "Find". The elipses were removed because no dialog is opened. This fix was accomplished by modifying the resources file to explicitly match the AutoProp.Name to the placeholder text. Closes #14398 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30125