starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14569] [MERGED] [SUI] Polish Launch Parameters setting controls #30157

New Issue
Open
opened 2026-01-31 09:39:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14569
Author: @carlos-zamora
Created: 12/15/2022
Status: ✅ Merged
Merged: 12/16/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/launch-params-cleanup

📝 Commits (3)

  • 5747c70 [SUI] Polish Launch Parameters setting controls
  • 011f004 let's be more descriptive in the preview
  • 048afbf Let Windows decide

📊 Changes

4 files changed (+37 additions, -21 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+32 -16)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+3 -3)

📄 Description

Summary of the Pull Request

Performs some cleanup in the Settings UI for the Launch Parameters settings:

  1. Updates all NumberBox controls in the Settings UI to have a Compact SpinButtonPlacementMode instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value.
  2. Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a Grid inside the main grid and applying a width to the number boxes.
  3. Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview.

Closes #14558

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14569 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 12/15/2022 **Status:** ✅ Merged **Merged:** 12/16/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/launch-params-cleanup` --- ### 📝 Commits (3) - [`5747c70`](https://github.com/microsoft/terminal/commit/5747c705ba409ac0f6a231d3b75c7ebe860d61f1) [SUI] Polish Launch Parameters setting controls - [`011f004`](https://github.com/microsoft/terminal/commit/011f00466828b84a6f8945295eaf88dd248c0965) let's be more descriptive in the preview - [`048afbf`](https://github.com/microsoft/terminal/commit/048afbf5e7bd70cb51880b21bd5d7a9b82b17a54) Let Windows decide ### 📊 Changes **4 files changed** (+37 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+32 -16) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+3 -3) </details> ### 📄 Description ## Summary of the Pull Request Performs some cleanup in the Settings UI for the Launch Parameters settings: 1. Updates all `NumberBox` controls in the Settings UI to have a `Compact` `SpinButtonPlacementMode` instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value. 2. Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a `Grid` inside the main grid and applying a width to the number boxes. 3. Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview. Closes #14558 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?