starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14629] [MERGED] Fix a crash on startup with a folder entry without entries #30165

New Issue
Closed
opened 2026-01-31 09:39:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14629
Author: @zadjii-msft
Created: 1/4/2023
Status: ✅ Merged
Merged: 1/19/2023
Merged by: @undefined

Base: main ← Head: dev/migrie/b/14557-clean-branch

📝 Commits (5)

  • c246dc9 this fixes it but this should have a test
  • 33cc584 this fixes the settings tests
  • 60656a2 tests!
  • 29a9c93 Merge remote-tracking branch 'origin/main' into dev/migrie/b/14557-clean-branch
  • 1e9e20b revert the thing

📊 Changes

4 files changed (+118 additions, -0 deletions)

View changed files

➕ src/cascadia/LocalTests_SettingsModel/NewTabMenuTests.cpp (+107 -0)
📝 src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp (+6 -0)
📝 src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj (+1 -0)
📝 src/cascadia/TerminalSettingsModel/FolderEntry.cpp (+4 -0)

📄 Description

_Entries was getting default constructed to nullptr. We should be careful about that.

Adds a test too, and fixes a regression in the local tests introduced in #13763.

Closes #14557

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14629 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/4/2023 **Status:** ✅ Merged **Merged:** 1/19/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/14557-clean-branch` --- ### 📝 Commits (5) - [`c246dc9`](https://github.com/microsoft/terminal/commit/c246dc9245f05b3dbc495420eb06021f220a31ac) this fixes it but this should have a test - [`33cc584`](https://github.com/microsoft/terminal/commit/33cc58430120e9e89aa933fed8697df95e862014) this fixes the settings tests - [`60656a2`](https://github.com/microsoft/terminal/commit/60656a2a13e98c27163dadcb3f02b5edaaa961a4) tests! - [`29a9c93`](https://github.com/microsoft/terminal/commit/29a9c93b0fc46e0eb399a61b9a8953987c1272ec) Merge remote-tracking branch 'origin/main' into dev/migrie/b/14557-clean-branch - [`1e9e20b`](https://github.com/microsoft/terminal/commit/1e9e20bcedf7da5c114758d2c811ded52d55aa7b) revert the thing ### 📊 Changes **4 files changed** (+118 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/cascadia/LocalTests_SettingsModel/NewTabMenuTests.cpp` (+107 -0) 📝 `src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp` (+6 -0) 📝 `src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/FolderEntry.cpp` (+4 -0) </details> ### 📄 Description `_Entries` was getting default constructed to `nullptr`. We should be careful about that. Adds a test too, and fixes a regression in the local tests introduced in #13763. Closes #14557 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?