[PR #14939] [CLOSED] Add tooltips to the Suggestions Control #30309

Open
opened 2026-01-31 09:39:59 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14939
Author: @zadjii-msft
Created: 3/1/2023
Status: Closed

Base: dev/migrie/fhl-2023/pwsh-autocomplete-demoHead: dev/migrie/f/3121-tooltips


📝 Commits (10+)

  • 06874ee dirty, but now with tooltips
  • c839bfa Cleanup for... review?
  • e09379c Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips
  • dcdb145 Dismiss tooltip on close
  • de56d9e Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips
  • 110bb7d surprisingly load bearing
  • 059fa07 Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips
  • a010e23 Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips
  • c49f765 Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips
  • 56cc44d Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips

📊 Changes

6 files changed (+123 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalApp/SuggestionsControl.cpp (+98 -4)
📝 src/cascadia/TerminalApp/SuggestionsControl.h (+5 -1)
📝 src/cascadia/TerminalApp/SuggestionsControl.xaml (+9 -0)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+8 -2)
📝 src/cascadia/TerminalSettingsModel/Command.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Command.idl (+2 -0)

📄 Description

targets #14938

These are currently powered by the "ToolTip" element in the completion protocol. This also adds room for "description"s in any action. This will be more relevant for Tasks, in #1595.

By all accounts, this could have been in the parent commit. I broke it apart for the ease of reviewing.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14939 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/1/2023 **Status:** ❌ Closed **Base:** `dev/migrie/fhl-2023/pwsh-autocomplete-demo` ← **Head:** `dev/migrie/f/3121-tooltips` --- ### 📝 Commits (10+) - [`06874ee`](https://github.com/microsoft/terminal/commit/06874ee321ada2f37777c1e3946645e469af25ac) dirty, but now with tooltips - [`c839bfa`](https://github.com/microsoft/terminal/commit/c839bfa2caf7b0f5218347c1ffa9421649022020) Cleanup for... review? - [`e09379c`](https://github.com/microsoft/terminal/commit/e09379c64f959a2c2d0d2d3798289ed20aa40efb) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips - [`dcdb145`](https://github.com/microsoft/terminal/commit/dcdb145500c9635f5d78a474519ed618f6664260) Dismiss tooltip on close - [`de56d9e`](https://github.com/microsoft/terminal/commit/de56d9e6c85eba4b0251e60fc59ad0d85715857a) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips - [`110bb7d`](https://github.com/microsoft/terminal/commit/110bb7da9c43dc002c8ff99609f971ddbb47a91f) surprisingly load bearing - [`059fa07`](https://github.com/microsoft/terminal/commit/059fa0709591b0206983c1e46c1053f57e8c8531) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips - [`a010e23`](https://github.com/microsoft/terminal/commit/a010e2375391fadc82b0a5271a0aacddf4dc0ca2) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips - [`c49f765`](https://github.com/microsoft/terminal/commit/c49f76512164d99abd2b4db8b9572ffe9abad332) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips - [`56cc44d`](https://github.com/microsoft/terminal/commit/56cc44d510b8a20e2b026a122733063dd186f25b) Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/migrie/f/3121-tooltips ### 📊 Changes **6 files changed** (+123 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/SuggestionsControl.cpp` (+98 -4) 📝 `src/cascadia/TerminalApp/SuggestionsControl.h` (+5 -1) 📝 `src/cascadia/TerminalApp/SuggestionsControl.xaml` (+9 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+8 -2) 📝 `src/cascadia/TerminalSettingsModel/Command.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.idl` (+2 -0) </details> ### 📄 Description _targets #14938_ These are currently powered by the `"ToolTip"` element in the completion protocol. This also adds room for `"description"`s in _any_ action. This will be more relevant for Tasks, in #1595. By all accounts, this could have been in the parent commit. I broke it apart for the ease of reviewing. * Related to #3121 * Doesn't close anything by itself --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:59 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30309