starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Feature Request - filledBox cursor should cover the whole unicode character #3813

New Issue
Closed
opened 2026-01-30 23:30:40 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 23:30:40 +00:00
Owner
Copy Link

Originally created by @dotSlashLu on GitHub (Sep 10, 2019).

Originally assigned to: @leonMSFT on GitHub.

Description of the new feature/enhancement

The filledBox cursor should not hide the covered character and it behaves differently for ASCII and wide characters:

  • For ASCII, the cursor covers the whole character:
    image
  • For wide characters, the cursor only covers part of the characters:
    image

Other terminal applications typically handle this well, take XShell for an example:
image
image
And the cursor automatically invert the covered character's color to show it properly without hiding it behind.

Originally created by @dotSlashLu on GitHub (Sep 10, 2019). Originally assigned to: @leonMSFT on GitHub. # Description of the new feature/enhancement The filledBox cursor should not hide the covered character and it behaves differently for ASCII and wide characters: - For ASCII, the cursor covers the whole character: ![image](https://user-images.githubusercontent.com/3133289/64631827-81a06c00-d42a-11e9-9810-87f3e1ddd162.png) - For wide characters, the cursor only covers part of the characters: ![image](https://user-images.githubusercontent.com/3133289/64631848-8e24c480-d42a-11e9-8fe3-383efa313ffb.png) Other terminal applications typically handle this well, take XShell for an example: ![image](https://user-images.githubusercontent.com/3133289/64632081-0095a480-d42b-11e9-873c-922d03df257c.png) ![image](https://user-images.githubusercontent.com/3133289/64632093-05f2ef00-d42b-11e9-82e1-3f0b9d780751.png) And the cursor automatically invert the covered character's color to show it properly without hiding it behind.
claunia commented 2026-01-30 23:30:42 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Sep 10, 2019):

Perhaps along with the UI category, there should be one for rendering?

@mdtauk commented on GitHub (Sep 10, 2019): Perhaps along with the UI category, there should be one for rendering?
claunia commented 2026-01-30 23:30:42 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 10, 2019):

@mdtauk You mean like Area-Rendering?

@DHowett-MSFT commented on GitHub (Sep 10, 2019): @mdtauk You mean like [Area-Rendering](https://github.com/microsoft/terminal/issues?q=is%3Aopen+is%3Aissue+label%3AArea-Rendering)?
claunia commented 2026-01-30 23:30:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 11, 2019):

Is this not the same as #1203?

@zadjii-msft commented on GitHub (Sep 11, 2019): Is this not the same as #1203?
claunia commented 2026-01-30 23:30:43 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Sep 11, 2019):

@mdtauk You mean like Area-Rendering?

I was looking at the Projects section, and only saw Design and Specification

:D

@mdtauk commented on GitHub (Sep 11, 2019): > @mdtauk You mean like [Area-Rendering](https://github.com/microsoft/terminal/issues?q=is%3Aopen+is%3Aissue+label%3AArea-Rendering)? I was looking at the Projects section, and only saw **Design** and **Specification** :D
claunia commented 2026-01-30 23:30:43 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 11, 2019):

@zadjii-msft nah this is "my character is double-cell, but my cursor is single-cell."

@DHowett-MSFT commented on GitHub (Sep 11, 2019): @zadjii-msft nah this is "my character is double-cell, but my cursor is single-cell."
claunia commented 2026-01-30 23:30:43 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 16, 2019):

Something something RenderData::GetCursorWidth

@DHowett-MSFT commented on GitHub (Sep 16, 2019): Something something `RenderData::GetCursorWidth`
claunia commented 2026-01-30 23:30:43 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 16, 2020):

You know, it's been like 5 months since the fix was proposed in #2932 and subsequently reverted. I don't totally remember what all went down with that, and reading through the notes didn't really clear it up for me. I think I'd be more comfortable with @miniksa handling this one.

We did a bunch to help our use-after-free's in the Terminal codebase since then, so maybe the original fix would just work by itself now.

@zadjii-msft commented on GitHub (Mar 16, 2020): You know, it's been like 5 months since the fix was proposed in #2932 and subsequently reverted. I don't totally remember what all went down with that, and reading through the notes didn't really clear it up for me. I think I'd be more comfortable with @miniksa handling this one. We did a bunch to help our use-after-free's in the Terminal codebase since then, so maybe the original fix would just work by itself now.
claunia commented 2026-01-30 23:30:43 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Mar 16, 2020):

I would like to do this, it's just that my stack of work is already so high and the world is sort of on fire. So we'll see.

@miniksa commented on GitHub (Mar 16, 2020): I would like to do this, it's just that my stack of work is already so high and the world is sort of on fire. So we'll see.
claunia commented 2026-01-30 23:30:44 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5319, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5319, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Area-Rendering Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3813
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?