starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code Cleanup - Member variables not initialized in GdiEngine's constructor #1203

New Issue
Open
opened 2026-01-30 22:19:01 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 22:19:01 +00:00
Owner
Copy Link

Originally created by @dlong11 on GitHub (May 18, 2019).

Minor Code cleanup

In src/renderer/gdi/state.cpp
GdiEngine's constructor is not initializing all of it's member variables.

_isTrueTypeFont
_fontCodepage
_tmFontMetrics
_coordFontLast
_psInvalidData

In Debug only
_debugWindow
_debugContext

As far as I can tell, none of the above variables are used before being initialized (in the normal code path). Most of these get set in UpdateFont and _CreateDebugWindow. It might make sense to make a pass and initialize these in the header with default values. Some members are correctly being set to a default value in the constructor, but it might be better for maintainability to remove those and initialize them in the header also.

Originally created by @dlong11 on GitHub (May 18, 2019). Minor Code cleanup In src/renderer/gdi/state.cpp GdiEngine's constructor is not initializing all of it's member variables. _isTrueTypeFont _fontCodepage _tmFontMetrics _coordFontLast _psInvalidData In Debug only _debugWindow _debugContext As far as I can tell, none of the above variables are used before being initialized (in the normal code path). Most of these get set in UpdateFont and _CreateDebugWindow. It might make sense to make a pass and initialize these in the header with default values. Some members are correctly being set to a default value in the constructor, but it might be better for maintainability to remove those and initialize them in the header also.
claunia added the Product-ConhostIssue-BugArea-Build labels 2026-01-30 22:19:01 +00:00
claunia commented 2026-01-30 22:19:02 +00:00
Author
Owner
Copy Link

@binarycrusader commented on GitHub (May 18, 2019):

Spot-checked a few, so marking as confirmed.

Two important guidelines to keep in mind for whomever wishes to resolve this:

C.48: Prefer in-class initializers to member initializers in constructors for constant initializers
C.45: Don’t define a default constructor that only initializes data members; use in-class member initializers instead

@binarycrusader commented on GitHub (May 18, 2019): Spot-checked a few, so marking as confirmed. Two important guidelines to keep in mind for whomever wishes to resolve this: [C.48: Prefer in-class initializers to member initializers in constructors for constant initializers](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c48-prefer-in-class-initializers-to-member-initializers-in-constructors-for-constant-initializers) [C.45: Don’t define a default constructor that only initializes data members; use in-class member initializers instead](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c45-dont-define-a-default-constructor-that-only-initializes-data-members-use-in-class-member-initializers-instead)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?