starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Cursor color should be part of color scheme, not profile #4641

New Issue
Closed
opened 2026-01-30 23:52:37 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 23:52:37 +00:00
Owner
Copy Link

Originally created by @cayv on GitHub (Oct 25, 2019).

Changes

I wrote a small script to import Terminal color schemes from VSCode themes. However, there's something I think is unintended design:

The "cursorColor" setting is currently part of the profile, not the color scheme. In my opinion it doesn't make sense, because by changing the color scheme of a given profile, the background color may be similar to the cursor color. Both settings should be coupled to each other for consistency.

Additional features

It'd be amazing if you guys could implement the few remaining color customization options from VSCode's terminal to reach feature parity. They are:

  • terminal.border: The color of the border that separates split panes within the terminal.
  • terminal.selectionBackground: The selection background color of the terminal.
  • terminalCursor.background: The background color of the terminal cursor. Allows customizing the color of a character overlapped by a block cursor.
Originally created by @cayv on GitHub (Oct 25, 2019). # Changes I wrote a small script to import Terminal color schemes from VSCode themes. However, there's something I think is unintended design: The "cursorColor" setting is currently part of the profile, not the color scheme. In my opinion it doesn't make sense, because by changing the color scheme of a given profile, the background color may be similar to the cursor color. Both settings should be coupled to each other for consistency. # Additional features It'd be amazing if you guys could implement the few remaining color customization options from VSCode's terminal to reach feature parity. They are: * terminal.border: The color of the border that separates split panes within the terminal. * terminal.selectionBackground: The selection background color of the terminal. * terminalCursor.background: The background color of the terminal cursor. Allows customizing the color of a character overlapped by a block cursor.
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-30 23:52:37 +00:00
claunia commented 2026-01-30 23:52:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2019):

Thanks for the report. I believe we have issues for a lot of these already, so lemme link them up:

  • "cursor color should be part of the color scheme": #764
  • Add a setting to manually set the Pane highlight color #3061
    • I suppose that there's not an issue for separator background in general. I believe we wanted to control that with XAML theming, though we don't really have a proper spec for what that looks like quite yet. @cinnamon-msft might be able to dig up the "theming" issue. It looks to me like we've danced around the idea in #1963, #1337, #3061/#3062, #2994, but never had a comprehensive answer.
  • There doesn't seem to currently be a "selection color" issue.
  • #1356 tracks wetting a FG/BG for the cursor in conhost, but not the terminal. There's also #1203 for "show the character under the cursor" in the Terminal, but again, not exactly what we're looking for here.

In general, it's really hard for us to track and resolve issues that have a bunch of suggestions in them. I'm going to move selection BG color to it's own issue, cursor bg/fg into #1203, and I'll make an issue for "theming" that will incorporate the pane border BG color.

Thanks for the feedback!

@zadjii-msft commented on GitHub (Oct 25, 2019): Thanks for the report. I believe we have issues for a lot of these already, so lemme link them up: * "cursor color should be part of the color scheme": #764 * Add a setting to manually set the Pane highlight color #3061 - I suppose that there's not an issue for separator background in general. I believe we wanted to control that with XAML theming, though we don't really have a proper spec for what that looks like quite yet. @cinnamon-msft might be able to dig up the "theming" issue. It looks to me like we've danced around the idea in #1963, #1337, #3061/#3062, #2994, but never had a comprehensive answer. * There doesn't seem to currently be a "selection color" issue. * #1356 tracks wetting a FG/BG for the cursor _in conhost_, but not the terminal. There's also #1203 for "show the character under the cursor" in the Terminal, but again, not exactly what we're looking for here. In general, it's really hard for us to track and resolve issues that have a bunch of suggestions in them. I'm going to move selection BG color to it's own issue, cursor bg/fg into #1203, and I'll make an issue for "theming" that will incorporate the pane border BG color. Thanks for the feedback!
claunia commented 2026-01-30 23:52:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2019):

/dup #764
/dup #3327
/dup #3326
/dup #1203

@zadjii-msft commented on GitHub (Oct 25, 2019): /dup #764 /dup #3327 /dup #3326 /dup #1203
claunia commented 2026-01-30 23:52:39 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 25, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Oct 25, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?