starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Audit uses of the screen buffer/alternate buffer, or come up with a design that makes this not an issue #3849

New Issue
Open
opened 2026-01-30 23:31:29 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:31:29 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Sep 13, 2019).

Is this indicative of a larger problem? Should we file an outstanding work item to audit all sites of manipulating the active buffer and/or somehow change the design such that the methods cannot accidentally be called without resolving which one is the active one first?

For the latter, my proposal would be to hide all the verbage methods off the base class and implement some sort of interface that holds them that is only returned when/if someone has correctly queried for the active one first. I'd accept competing proposals, though.

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/2729#issuecomment-530923095

Originally created by @DHowett-MSFT on GitHub (Sep 13, 2019). Is this indicative of a larger problem? Should we file an outstanding work item to audit all sites of manipulating the active buffer and/or somehow change the design such that the methods cannot accidentally be called without resolving which one is the active one first? For the latter, my proposal would be to hide all the verbage methods off the base class and implement some sort of interface that holds them that is only returned when/if someone has correctly queried for the active one first. I'd accept competing proposals, though. _Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/2729#issuecomment-530923095_
claunia added the Product-ConhostIssue-TaskArea-VT labels 2026-01-30 23:31:30 +00:00
claunia commented 2026-01-30 23:31:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 13, 2019):

This would be a great place to discuss why the alt buffer is a sidecar to the current buffer instead of a new console buffer (which is a supported scenario.) If the alt buffer were a true top-level buffer (possibly with a link to its originating buffer), every API that look up the "current buffer" would get the right one.

@DHowett-MSFT commented on GitHub (Sep 13, 2019): This would be a great place to discuss why the alt buffer is _a sidecar to the current buffer_ instead of _a new console buffer_ (which is a supported scenario.) If the alt buffer were a true top-level buffer (possibly with a link to its originating buffer), every API that look up the "current buffer" would get the right one.
claunia commented 2026-01-30 23:31:30 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Sep 13, 2019):

What is the performance hit, if the command buffer was stored as strings, and re-drawn when needed - as opposed to being stored in texture memory?

@mdtauk commented on GitHub (Sep 13, 2019): What is the performance hit, if the command buffer was stored as strings, and re-drawn when needed - as opposed to being stored in texture memory?
claunia commented 2026-01-30 23:31:31 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 13, 2019):

Wha? It is. We don’t cache prerendered screen content.

@DHowett-MSFT commented on GitHub (Sep 13, 2019): Wha? It is. We don’t cache prerendered screen content.
claunia commented 2026-01-30 23:31:31 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 13, 2019):

This isn’t related to rendering :)

@DHowett-MSFT commented on GitHub (Sep 13, 2019): This isn’t related to rendering :)
claunia commented 2026-01-30 23:31:31 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Sep 13, 2019):

Ignore me then - I always think in UI lol

@mdtauk commented on GitHub (Sep 13, 2019): Ignore me then - I always think in UI lol
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Task Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3849
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?