starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Remove usages of old safe math #5829

New Issue
Open
opened 2026-01-31 00:22:55 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:22:55 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Jan 8, 2020).

There are approximately 79 uses of old safe math. (a.k.a. the LongAdd, ShortAdd, and friends from intsafe.h).

This task represents removing them and transitioning them to an appropriate safe/saturating math function from the chromium safe math library introduced in #4144.

After removing usages of the old safe math functions, also remove the intsafe.h header.

Files with old safe math as of this writing:

  • TerminalControl: TSFInputControl.cpp
  • TerminalCore: TerminalDispatch.cpp
  • TerminalCore: TerminalSelection.cpp
  • Host: directio.cpp
  • RendererGdi: invalidate.cpp
  • RendererGdi: math.cpp
  • RendererGdi: paint.cpp
  • RendererVt: paint.cpp
  • TerminalAdapter: adaptDispatch.cpp
  • Types: viewport.cpp
  • Types: WindowUiaProviderBase.cpp
Originally created by @miniksa on GitHub (Jan 8, 2020). There are approximately 79 uses of old safe math. (a.k.a. the `LongAdd`, `ShortAdd`, and friends from `intsafe.h`). This task represents removing them and transitioning them to an appropriate safe/saturating math function from the chromium safe math library introduced in #4144. After removing usages of the old safe math functions, also remove the `intsafe.h` header. Files with old safe math as of this writing: - TerminalControl: TSFInputControl.cpp - TerminalCore: TerminalDispatch.cpp - TerminalCore: TerminalSelection.cpp - Host: directio.cpp - RendererGdi: invalidate.cpp - RendererGdi: math.cpp - RendererGdi: paint.cpp - RendererVt: paint.cpp - TerminalAdapter: adaptDispatch.cpp - Types: viewport.cpp - Types: WindowUiaProviderBase.cpp
claunia commented 2026-01-31 00:22:56 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jan 8, 2020):

If @j4james doesn't take this, whomever takes this should consult with @j4james on the ones in adaptDispatch.cpp because they should likely be saturating math instead of failing when exceeding bounds as they are today.

@miniksa commented on GitHub (Jan 8, 2020): If @j4james doesn't take this, whomever takes this should consult with @j4james on the ones in `adaptDispatch.cpp` because they should likely be saturating math instead of failing when exceeding bounds as they are today.
claunia commented 2026-01-31 00:22:56 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 8, 2020):

I don't mind doing this eventually, but I have bunch of stuff in progress that I would like to try and get finished first. If anyone else wants to take it on, though, I would recommend waiting at least until #3628 is merged, because there is a fair amount of safe math code in AdaptDispatch that will be nuked by that PR, so you'll be wasting your time if you're trying to refactor that.

On a similar note, I expect issue #3849 will end up replacing most, if not all, of the TerminalDispatch code. That said, it may be a long time before that happens, so it's possibly still worth cleaning up the existing code in the mean time.

@j4james commented on GitHub (Jan 8, 2020): I don't mind doing this eventually, but I have bunch of stuff in progress that I would like to try and get finished first. If anyone else wants to take it on, though, I would recommend waiting at least until #3628 is merged, because there is a fair amount of safe math code in `AdaptDispatch` that will be nuked by that PR, so you'll be wasting your time if you're trying to refactor that. On a similar note, I expect issue #3849 will end up replacing most, if not all, of the `TerminalDispatch` code. That said, it may be a long time before that happens, so it's possibly still worth cleaning up the existing code in the mean time.
claunia commented 2026-01-31 00:22:56 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 9, 2020):

One other thing I wanted to add: there is another category of intsafe routines which I think isn't covered by the 79 uses mentioned above, and that is the type conversion functions, e.g. SizeTToShort. In the VT code, I think many of those would probably need to be converted to something like a saturated_cast when using the new chromium lib.

@j4james commented on GitHub (Jan 9, 2020): One other thing I wanted to add: there is another category of intsafe routines which I think isn't covered by the 79 uses mentioned above, and that is the type conversion functions, e.g. `SizeTToShort`. In the VT code, I think many of those would probably need to be converted to something like a `saturated_cast` when using the new chromium lib.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Product-Conhost Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?