starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

schema: add support for Visual Studio Code color picker #4587

New Issue
Closed
opened 2026-01-30 23:51:16 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 23:51:16 +00:00
Owner
Copy Link

Originally created by @mveril on GitHub (Oct 22, 2019).

Environment

Windows build number: 10.0.19002.0
Windows Terminal version (if applicable): 0.5.2762.0 from the Microsoft Store
 

Any other software?
Visual Studio Code version : 1.39.2

Steps to reproduce

Open the profile.json in Visual Studio Code and see the behavior of color setting like profile background.

Expected behavior

When I open the profile.json in VSCode and I want to set a color, it may be better if the color can be edited with the VSCode colorpcker.
It's can be obtained by set format: color in the json scheme, but I don't know how to disable alpha and only support "^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})$" style.
image

Actual behavior

The color must be set manually with the #rrggbb code
Here an example.
image
Thank you

Originally created by @mveril on GitHub (Oct 22, 2019). # Environment ```none Windows build number: 10.0.19002.0 Windows Terminal version (if applicable): 0.5.2762.0 from the Microsoft Store Any other software? Visual Studio Code version : 1.39.2 ``` # Steps to reproduce Open the `profile.json` in Visual Studio Code and see the behavior of color setting like profile `background`. # Expected behavior When I open the `profile.json` in VSCode and I want to set a color, it may be better if the color can be edited with the VSCode colorpcker. It's can be obtained by set `format: color` in the json scheme, but I don't know how to disable alpha and only support `"^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})$"` style. ![image](https://user-images.githubusercontent.com/15073055/67272385-b6d5ba80-f4bc-11e9-9a15-512ff3ca13c0.png) # Actual behavior The color must be set manually with the `#rrggbb` code Here an example. ![image](https://user-images.githubusercontent.com/15073055/67271655-3f535b80-f4bb-11e9-8aeb-e41a0aa24c05.png) Thank you
claunia commented 2026-01-30 23:51:17 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 22, 2019):

That’s convenient haha. I wonder if our settings parser supports the alpha values? If it does, it might be just an update to the schema then.

@carlos-zamora commented on GitHub (Oct 22, 2019): That’s convenient haha. I wonder if our settings parser supports the alpha values? If it does, it might be just an update to the schema then.
claunia commented 2026-01-30 23:51:18 +00:00
Author
Owner
Copy Link

@mveril commented on GitHub (Oct 22, 2019):

That’s convenient haha. I wonder if our settings parser supports the alpha values? If it does, it might be just an update to the schema then.

Thank you.
OK alpha don't work and also may be confusing, but it may be possible to disable alpha or specify the color syntax in the json schema. I don't know.

@mveril commented on GitHub (Oct 22, 2019): > That’s convenient haha. I wonder if our settings parser supports the alpha values? If it does, it might be just an update to the schema then. Thank you. OK alpha don't work and also may be confusing, but it may be possible to disable alpha or specify the color syntax in the json schema. I don't know.
claunia commented 2026-01-30 23:51:18 +00:00
Author
Owner
Copy Link

@TheBrain0110 commented on GitHub (Nov 12, 2019):

Fun fact: The color syntax is already specified in the json schema to not allow alpha values. It doesn't stop VSCode's color picker from letting you pick a color with an alpha channel, but then it marks the line with a warning that it doesn't conform to the schema, which seems like a sufficient solution.

d2ca3c1fb0/doc/cascadia/profiles.schema.json (L5-L10)

Making the VSCode color picker work was a single line, which I just did for myself before even looking through the existing issues. See my PR #3530

5894a3a166/doc/cascadia/profiles.schema.json (L5-L11)

@TheBrain0110 commented on GitHub (Nov 12, 2019): Fun fact: The color syntax is *already* specified in the json schema to not allow alpha values. It doesn't stop VSCode's color picker from letting you pick a color with an alpha channel, but then it marks the line with a warning that it doesn't conform to the schema, which seems like a sufficient solution. https://github.com/microsoft/terminal/blob/d2ca3c1fb06779dc2fa828d0205122f4b2acf5f4/doc/cascadia/profiles.schema.json#L5-L10 Making the VSCode color picker work was a single line, which I just did for myself before even looking through the existing issues. See my PR #3530 https://github.com/microsoft/terminal/blob/5894a3a166e80873652cc4a62ad0c7d74ad27fd0/doc/cascadia/profiles.schema.json#L5-L11
claunia commented 2026-01-30 23:51:18 +00:00
Author
Owner
Copy Link

@mveril commented on GitHub (Nov 17, 2019):

Thank you @TheBrain0110 it's work fine ! Unfortunately the alpha slider cannot be disabled on VSCode

@mveril commented on GitHub (Nov 17, 2019): Thank you @TheBrain0110 it's work fine ! Unfortunately the alpha slider cannot be disabled on VSCode
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Schema Area-Settings Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4587
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?