starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Selection Color should invert selected text color #4980

New Issue
Closed
opened 2026-01-31 00:02:09 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:02:09 +00:00
Owner
Copy Link

Originally created by @javierdlg on GitHub (Nov 13, 2019).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): All

Steps to reproduce

  1. Open the terminal.
  2. Select some text.

Expected behavior

Selected text should invert the text colors:

Actual behavior

Text maintains it's original color which leads to contrast issues.
image

Notes

Powershell and CMD both invert the text colors when selected, which would fix the contrast ratio accessibility issue present in the terminal:
image

Originally created by @javierdlg on GitHub (Nov 13, 2019). # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): All ``` # Steps to reproduce 1. Open the terminal. 1. Select some text. # Expected behavior Selected text should invert the text colors: # Actual behavior Text maintains it's original color which leads to contrast issues. ![image](https://user-images.githubusercontent.com/2334756/68795006-ed5aad00-0604-11ea-822f-51f3ae4d9c9c.png) # Notes Powershell and CMD both invert the text colors when selected, which would fix the contrast ratio accessibility issue present in the terminal: ![image](https://user-images.githubusercontent.com/2334756/68793524-3b21e600-0602-11ea-820f-c1885cb48aa6.png)
claunia commented 2026-01-31 00:02:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2019):

oh no

This is hard to very hard on the scale of tasks, unfortunately.

GDI has a very handy function for inverting the colors of a region of the window. unfortunately, DX has so such equivalent function. I believe @miniksa has said something in that past about rendering the frame, then specially inverting the selected area in another rendering pass? He can elaborate more.

@zadjii-msft commented on GitHub (Nov 13, 2019): _oh no_ This is hard to _very hard_ on the scale of tasks, unfortunately. GDI has a very handy function for inverting the colors of a region of the window. unfortunately, DX has so such equivalent function. I believe @miniksa has said something in that past about rendering the frame, then specially inverting the selected area in another rendering pass? He can elaborate more.
claunia commented 2026-01-31 00:02:11 +00:00
Author
Owner
Copy Link

@javierdlg commented on GitHub (Nov 13, 2019):

How about being able to choose the selected text foreground color? This could potentially solve the contrast ratio issue on selected text and not force us to vet all the colors against two background colors for every theme.

@javierdlg commented on GitHub (Nov 13, 2019): How about being able to choose the selected text foreground color? This could potentially solve the contrast ratio issue on selected text and not force us to vet all the colors against two background colors for every theme.
claunia commented 2026-01-31 00:02:11 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Nov 13, 2019):

Didn't #3471 committed today literally just do this?

@miniksa commented on GitHub (Nov 13, 2019): Didn't #3471 committed today literally just do this?
claunia commented 2026-01-31 00:02:11 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Nov 13, 2019):

Didn't #3471 committed today literally just do this?

It only includes a Selection Background colour. I did make the suggestion there should also be a Selection Foreground colour.

@mdtauk commented on GitHub (Nov 13, 2019): > Didn't #3471 committed today literally just do this? It only includes a Selection Background colour. I did make the suggestion there should also be a Selection Foreground colour.
claunia commented 2026-01-31 00:02:11 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 14, 2019):

We're open to contributions to our DX renderer. Thanks!

@DHowett-MSFT commented on GitHub (Nov 14, 2019): We're open to contributions to our DX renderer. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Area-Rendering Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4980
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?