starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Certain invalid UTF-8 sequences can cause the output to fail #5734

New Issue
Closed
opened 2026-01-31 00:20:20 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:20:20 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Dec 30, 2019).

Environment

Windows build number: Version 10.0.18362.418
Windows Terminal version (if applicable): 0.7.3451.0

Steps to reproduce

  1. Open a bash shell.
  2. Execute the command printf "\xA3"

Expected behavior

I'd expect to see something like the U+FFFD error character, or worst case nothing at all.

Actual behavior

The output is aborted with an error:

-bash: printf: write error: Input/output error

This looks similar to issue #3320, but PR #3380 doesn't fix it, and a recent build from master still produces the problem.

I did a bit of experimenting, and if you replace the MB_ERR_INVALID_CHARS with 0 in the _ParseFullRange method, that seems to help, although I don't know whether that's the right solution.

I know there was a follow up task created which may end up fixing this (#3378), but I thought it best to have the issue filed as an actual bug. If you don't think that's necessary, though, you can always close this as a dup.

Originally created by @j4james on GitHub (Dec 30, 2019). # Environment Windows build number: Version 10.0.18362.418 Windows Terminal version (if applicable): 0.7.3451.0 # Steps to reproduce 1. Open a bash shell. 2. Execute the command `printf "\xA3"` # Expected behavior I'd expect to see something like the U+FFFD error character, or worst case nothing at all. # Actual behavior The output is aborted with an error: -bash: printf: write error: Input/output error This looks similar to issue #3320, but PR #3380 doesn't fix it, and a recent build from master still produces the problem. I did a bit of experimenting, and if you replace the `MB_ERR_INVALID_CHARS` with 0 in the [`_ParseFullRange`](https://github.com/microsoft/terminal/blob/126d489af97fdafbb3194c0cd32f9f99b031f376/src/host/utf8ToWideCharParser.cpp#L296) method, that seems to help, although I don't know whether that's the right solution. I know there was a follow up task created which may end up fixing this (#3378), but I thought it best to have the issue filed as an actual bug. If you don't think that's necessary, though, you can always close this as a dup.
claunia commented 2026-01-31 00:20:22 +00:00
Author
Owner
Copy Link

@german-one commented on GitHub (Jan 1, 2020):

#4093 could be a first step. I'm quite certain the functions and classes could be used to update Utf8ToWideCharParser in a proper way.

@german-one commented on GitHub (Jan 1, 2020): #4093 could be a first step. I'm quite certain the functions and classes could be used to update `Utf8ToWideCharParser` in a proper way.
claunia commented 2026-01-31 00:20:22 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 2, 2020):

@german-one I'm a bit confused. Is #4093 still a work in progress, or is it not intended to replace the conhost utf8 parser yet? I was hoping I could just merge your PR and it would fix the problems I was seeing, but that doesn't seem to be the case.

@j4james commented on GitHub (Jan 2, 2020): @german-one I'm a bit confused. Is #4093 still a work in progress, or is it not intended to replace the conhost utf8 parser yet? I was hoping I could just merge your PR and it would fix the problems I was seeing, but that doesn't seem to be the case.
claunia commented 2026-01-31 00:20:22 +00:00
Author
Owner
Copy Link

@german-one commented on GitHub (Jan 2, 2020):

It's intended to be the first step. My implementation is able to supersede Utf8ToWideCharParser entirely. And indeed that's the next item on my list. But first I want to get the hand-rolled conversions reviewed by the core contributors. Unifying the UTF-8 parsers is too much for only one PR I guess.

@german-one commented on GitHub (Jan 2, 2020): It's intended to be the first step. My implementation is able to supersede `Utf8ToWideCharParser` entirely. And indeed that's the next item on my list. But first I want to get the hand-rolled conversions reviewed by the core contributors. Unifying the UTF-8 parsers is too much for only one PR I guess.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Area-Server Issue-Bug Needs-Tag-Fix Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?