starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Display a warning when a user tries to bind an action to multiple keys in a single chord #5952

New Issue
Closed
opened 2026-01-31 00:26:20 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:26:20 +00:00
Owner
Copy Link

Originally created by @angelog0 on GitHub (Jan 15, 2020).

After upgrading to WT 0.8, I added this to my profile.json:

"keybindings":
    [
        // "index": 1 ==> "Ubuntu"
        { "keys": ["ctrl+2+plus"],
          "command": {"action": "splitPane", "split": "vertical", "index": 1}
        },
        { "keys": ["ctrl+2+-"],
          "command": {"action": "splitPane", "split": "horizontal", "index": 1}
        }//,
        // "index": 2 ==> "CMD"
        // { "keys": ["ctrl+3+plus"],
        //   "command": {"action": "splitPane", "split": "vertical", "index": 2}
        // },
        // { "keys": ["ctrl+3+-"],
        //   "command": {"action": "splitPane", "split": "horizontal", "index": 2}
        // }
    ]

and it works as expected: profile index 0 is MSYS2 and index 1 is Ubuntu, so ctrl+2+... can split current profile calling Ubuntu.

If I uncomment the other lines (index 2 for CMD), both ctrl+2+... and ctrl+3+... open CMD profile. In short adding similar lines for other profile, always open the last profile and not what they should open...

I wonder what is wrong with those lines.. maybe i have misunderstood? Thanks...

Originally created by @angelog0 on GitHub (Jan 15, 2020). After upgrading to WT 0.8, I added this to my `profile.json`: ``` "keybindings": [ // "index": 1 ==> "Ubuntu" { "keys": ["ctrl+2+plus"], "command": {"action": "splitPane", "split": "vertical", "index": 1} }, { "keys": ["ctrl+2+-"], "command": {"action": "splitPane", "split": "horizontal", "index": 1} }//, // "index": 2 ==> "CMD" // { "keys": ["ctrl+3+plus"], // "command": {"action": "splitPane", "split": "vertical", "index": 2} // }, // { "keys": ["ctrl+3+-"], // "command": {"action": "splitPane", "split": "horizontal", "index": 2} // } ] ``` and it works as expected: profile `index 0` is MSYS2 and `index 1` is Ubuntu, so `ctrl+2+...` can split current profile calling Ubuntu. If I uncomment the other lines (`index 2` for CMD), both `ctrl+2+...` and `ctrl+3+...` open CMD profile. In short adding similar lines for other profile, always open the last profile and not what they should open... I wonder what is wrong with those lines.. maybe i have misunderstood? Thanks...
claunia commented 2026-01-31 00:26:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 15, 2020):

Oh we should probably display some sort of warning in this case. You can't really add keybindings with multiple keys like that. You can have any combination of Ctrl, Alt and Shift, but only one actual key like 3 or +. I bet as we're deserializing this, we're finding the 3, setting the Vkey to 3, then finding the + and resetting the vkey to +, effectively overriding the other binding like it.

We should be able to catch this at parse time and display a warning to the user.

@zadjii-msft commented on GitHub (Jan 15, 2020): Oh we should probably display some sort of warning in this case. You can't really add keybindings with multiple _keys_ like that. You can have any combination of <kbd>Ctrl</kbd>, <kbd>Alt</kbd> and <kbd>Shift</kbd>, but only one actual key like <kbd>3</kbd> or <kbd>+</kbd>. I bet as we're deserializing this, we're finding the <kbd>3</kbd>, setting the `Vkey` to `3`, then finding the <kbd>+</kbd> and resetting the vkey to `+`, effectively overriding the other binding like it. We should be able to catch this at parse time and display a warning to the user.
claunia commented 2026-01-31 00:26:21 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 16, 2020):

We should definitely warn about this, but the feature you'll eventually want is #1334. That one's not slated for 1.0.

@DHowett-MSFT commented on GitHub (Jan 16, 2020): We should definitely warn about this, but the feature you'll eventually want is #1334. That one's not slated for 1.0.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?