starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Popup windows can cause weird color updates in conhost #8658

New Issue
Closed
opened 2026-01-31 01:34:48 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 01:34:48 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 29, 2020).

Environment

Windows build number: Version 10.0.18362.720

Steps to reproduce

  1. Open a conhost cmd shell.
  2. Open the Properties dialog and make sure Terminal Colors are unchecked, and the Screen Background is set to black (index 0). Restart the shell if you had to change the colors.
  3. Do something in the shell to fill the screen with text, e.g. dir /?.
  4. Press F7 to popup the command history window.
  5. While the popup is still visible, open the Properties dialog again, and change the Screen Background to blue (index 1).
  6. After saving the properties, press Esc to close the history popup.

Expected behavior

The text beneath the popup should be restored with its original color, or otherwise the entire screen background should have changed to blue.

Actual behavior

Most of the screen remains black, but the lines beneath the popup have changed to blue.

image

What's happening is that the Popup class is trying to be clever, and update the area beneath it to match the changes to the default colors, assuming the rest of the screen is also going to be changed (which is what used to happen in the v1 console). But since that's no longer the case, it's actually just breaking things.

You could argue that we should be fixing the fact that the default screen colors don't update. But the best way to do that (at least in my opinion), is the solution I proposed for #5952. With that fix in place, the default colors just update automatically, so there should be no need for the popup window to perform any additional color mapping.

And in addition to updating the default colors, it also tries to update what it thinks are popup colors (or their inverse). So any text that just happens to match those colors can find itself being updated as well. I assume this is to handle the case of a popup on top of another popup, but the popup window itself doesn't update when you change those colors, so I can't see why it would need to update another popup beneath it.

In short, I would like to propose we get rid of this code altogether, unless someone knows of a genuine need for it. Right now it seems to be doing more harm than good.

Originally created by @j4james on GitHub (May 29, 2020). # Environment Windows build number: Version 10.0.18362.720 # Steps to reproduce 1. Open a conhost cmd shell. 2. Open the _Properties_ dialog and make sure _Terminal Colors_ are unchecked, and the _Screen Background_ is set to black (index 0). Restart the shell if you had to change the colors. 3. Do something in the shell to fill the screen with text, e.g. `dir /?`. 4. Press <kbd>F7</kbd> to popup the command history window. 5. While the popup is still visible, open the _Properties_ dialog again, and change the _Screen Background_ to blue (index 1). 6. After saving the properties, press <kbd>Esc</kbd> to close the history popup. # Expected behavior The text beneath the popup should be restored with its original color, or otherwise the entire screen background should have changed to blue. # Actual behavior Most of the screen remains black, but the lines beneath the popup have changed to blue. ![image](https://user-images.githubusercontent.com/4181424/83203157-b8e1b500-a140-11ea-8199-e34c3c6b1868.png) What's happening is that the `Popup` class is trying to be clever, and update the area beneath it to match the changes to the default colors, assuming the rest of the screen is also going to be changed (which is what used to happen in the v1 console). But since that's no longer the case, it's actually just breaking things. You could argue that we should be fixing the fact that the default screen colors don't update. But the best way to do that (at least in my opinion), is the solution I proposed for #5952. With that fix in place, the default colors just update automatically, so there should be no need for the popup window to perform any additional color mapping. And in addition to updating the default colors, it also tries to update what it thinks are popup colors (or their inverse). So any text that just happens to match those colors can find itself being updated as well. I assume this is to handle the case of a popup on top of another popup, but the popup window itself doesn't update when you change those colors, so I can't see why it would need to update another popup _beneath_ it. In short, I would like to propose we get rid of this code altogether, unless someone knows of a genuine need for it. Right now it seems to be doing more harm than good.
claunia commented 2026-01-31 01:34:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 1, 2020):

Yep that looks like a real bug to me. Thanks for the investigation so far!

@zadjii-msft commented on GitHub (Jun 1, 2020): Yep that looks like a real bug to me. Thanks for the investigation so far!
claunia commented 2026-01-31 01:34:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 18, 2020):

:tada:This issue was addressed in #6358, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.🎉

Handy links:

@ghost commented on GitHub (Jun 18, 2020): :tada:This issue was addressed in #6358, which has now been successfully released as `Windows Terminal Preview v1.1.1671.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1671.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Priority-3 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?