Alt+ Enter rendering error #7019

Closed
opened 2026-01-31 00:53:04 +00:00 by claunia · 4 comments
Owner

Originally created by @Po-wei on GitHub (Mar 20, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: [[Version 10.0.18363.720]]
Windows Terminal version (if applicable):  0.10.761.0

Any other software?

Steps to reproduce

There are two bugs of Alt+Enter behavior.
Text Disappear && Prompt Duplicate
a. open terminal with WSL
b. type: ls -la or do whatever will print content over a page
c. mouse scroll up to the top
d. type Alt+Enter to Fullscreen
e. text outside orignal windows do not render.
d. scroll down to the bottom: type Alt+Enter several times
f. prompt duplicate several times.

I used zsh with the right side Prompt
image

Actual behavior

image

image

Expected behavior

We need to scroll the terminal to force a re-rendering.
image

Originally created by @Po-wei on GitHub (Mar 20, 2020). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: [[Version 10.0.18363.720]] Windows Terminal version (if applicable): 0.10.761.0 Any other software? ``` # Steps to reproduce There are two bugs of Alt+Enter behavior. Text Disappear && Prompt Duplicate a. open terminal with WSL b. type: ls -la or do whatever will print content over a page c. **mouse scroll up** to the top d. type Alt+Enter to Fullscreen e. text outside orignal windows do not render. d. scroll down to the bottom: type Alt+Enter several times f. prompt duplicate several times. I used zsh with the right side Prompt ![image](https://user-images.githubusercontent.com/17596021/77134780-bae31580-6a25-11ea-998d-0e3f965bf54e.png) # Actual behavior ![image](https://user-images.githubusercontent.com/17596021/77134938-92a7e680-6a26-11ea-9421-7db56a3d9914.png) ![image](https://user-images.githubusercontent.com/17596021/77134715-76577a00-6a25-11ea-99d7-26255428b82d.png) # Expected behavior We need to scroll the terminal to force a re-rendering. ![image](https://user-images.githubusercontent.com/17596021/77134701-617ae680-6a25-11ea-9754-4dd0c2195a22.png) <!-- What's actually happening? -->
Author
Owner

@zadjii-msft commented on GitHub (Mar 20, 2020):

@Po-wei could you share your profiles.json?

The second screenshot you've shared is certainly very peculiar. It almost looks like the behavior I'd expect from 0.9, but not 0.10. Like the conpty didn't resize to the newly fullscreen'd size. Especially considering the green from the .tooling line doesn't extend to take the full width of the buffer. I'd bet the buffer didn't actually increase in size.

Oh wow actually I just repro'd that immediately. It's almost as if we don't invalidate the screen or something on a resize.

WE almost certainly don't, because we were repainting the entire screen before on a resize, so this wasn't a problem. Yea okay I know what the fix is.

@zadjii-msft commented on GitHub (Mar 20, 2020): @Po-wei could you share your `profiles.json`? The second screenshot you've shared is certainly very peculiar. It almost looks like the behavior I'd expect from 0.9, but not 0.10. Like the conpty didn't resize to the newly fullscreen'd size. Especially considering the green from the `.tooling` line doesn't extend to take the full width of the buffer. I'd bet the buffer didn't actually increase in size. Oh wow actually I just repro'd that immediately. It's almost as if we don't invalidate the screen or something on a resize. WE almost certainly don't, because we were repainting the entire screen before on a resize, so this wasn't a problem. Yea okay I know what the fix is.
Author
Owner

@Po-wei commented on GitHub (Mar 20, 2020):

@zadjii-msft
My profile.json of terminal
https://gist.github.com/Po-wei/5512e0a85ea53ad6075a292c2e9bc77f
It is a pretty normal profile.

@Po-wei commented on GitHub (Mar 20, 2020): @zadjii-msft My profile.json of terminal https://gist.github.com/Po-wei/5512e0a85ea53ad6075a292c2e9bc77f It is a pretty normal profile.
Author
Owner

@zadjii-msft commented on GitHub (Mar 20, 2020):

@Po-wei Thanks for sharing that. I originally thought you might be hitting the "a really large history size causes weird behavior on a maximize", but I was able to actually figure this out already. The fix is already in PR :)

@zadjii-msft commented on GitHub (Mar 20, 2020): @Po-wei Thanks for sharing that. I originally thought you might be hitting the "a really large history size causes weird behavior on a maximize", but I was able to actually figure this out already. The fix is already in PR :)
Author
Owner

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5046, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5046, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7019