starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Scenario] 2 Resize 2 Reflow #8006

New Issue
Open
opened 2026-01-31 01:18:28 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 01:18:28 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 7, 2020).

During 1.0, we discovered a ton of bugs in our resize with reflow implementation, and now that we need to keep both the conpty and the terminal in sync on these things, it's more important than ever to do these things right.

I'm collecting up all the straggling tasks I've found that might possibly be related.

This is a combo of "Make Reflow work correctly", and "Get rid of the spaghetti in the VtEngine related to line wrapping"

(see also #4200, the original reflow mega thread)

Issues

Things I think will all be fixed by #8000

PRs

Many of these are 1.0 PRs, but they've all got important context.

1.0 PRs
  • Don't reflow a line as wrapped if it broke on the last cell #5368
Originally created by @zadjii-msft on GitHub (May 7, 2020). During 1.0, we discovered a ton of bugs in our resize with reflow implementation, and now that we need to keep both the conpty and the terminal in sync on these things, it's more important than ever to do these things right. I'm collecting up all the straggling tasks I've found that might _possibly_ be related. This is a combo of "Make Reflow work correctly", and "Get rid of the spaghetti in the VtEngine related to line wrapping" (see also #4200, the original reflow mega thread) ## Issues * [ ] #796 Resize reflow tests * [ ] #797 Resize with Reflow loses leading spaces on resize operation * [ ] #3088 WSL Terminal Line Endings (the "exact wrap" bug) * #802 [host] If a line is exactly the width of the buffer and you increase the buffer width, it will wrap incorrectly resize reflow * [ ] #5228 Conpty: Additional `ScrollFrame` optimizations * [x] [REGRESSION >0.11.1251] Backward-kill-word after line wrapping in powershell doesn't clear exited line properly #5839 (PR #5870) * [ ] MSFT:19446208 - [This code in `TextBuffer::Reflow`](https://github.com/microsoft/terminal/blob/cf62922ad8da67464c517931b89f3fc098381b76/src/buffer/out/textBuffer.cpp#L2034-L2043) * [ ] #6566 Some text not displayed when the screen scrolls * [ ] #6901 When Copying, Line Wrapped Text Is Inconsistently Broken Into Multiple Lines - [ ] #10833 Multi-line paste with WSL omits and splices together lines - [ ] #11739 - [ ] #11809 * [ ] #7028 No line wrap at the bottom of the Terminal window when entering text in TCC * [ ] #7253 Un-snapping Terminal Placing Cursor in Middle of Previous Command's Output * (actually has a consistent repro) * [ ] #6987 Rendering errors in tmux split panes - [ ] This might also be "Tmux pane content gets garbled after refreshing tmux client #4029" * [ ] #7019 conpty exhibits pathological performance on scrolling region redraw (repaints entire screen) * [ ] #7479 * [ ] #7581 * [ ] #12440, which might just be #780 ### Things I think will all be fixed by #8000 * [ ] #6546 Command History on wrong line * [ ] #10130 * [ ] #10848 Cursor position is lost when resizing the window if not on the bottom line * [ ] #10868 also looks like this ## PRs Many of these are 1.0 PRs, but they've all got important context. <details> <summary> 1.0 PRs </summary> * [x] Don't remove spaces when printing a new bottom line with a background color #5550 * [x] Fix wrapped lines in `less` in Git for Windows #5771 * [x] Don't duplicate spaces from potentially-wrapped EOL-deferred lines #5398 * [x] Add a test to cover #5428 #5449 * [x] Fix copying wrapped lines by implementing better scrolling #5181 * [x] Emit lines wrapped due to spaces at the end correctly #5294 * [x] Fix an accidental regression from #5771 #5870 </details> * [ ] Don't reflow a line as wrapped if it broke on the last cell #5368
claunia added the Product-ConptyArea-CodeHealthIssue-Scenario labels 2026-01-31 01:18:29 +00:00
claunia commented 2026-01-31 01:18:29 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 12, 2020):

2 Resize 2 Reflow

I'm pretty sure we're at least on Resize & Reflow: Tokyo Drift by now if not further into the series.

@miniksa commented on GitHub (May 12, 2020): > 2 Resize 2 Reflow I'm pretty sure we're at least on `Resize & Reflow: Tokyo Drift` by now if not further into the series.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Scenario Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?