starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Shortcut Icon Search doesn't look at fully qualified path #8690

New Issue
Closed
opened 2026-01-31 01:35:38 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 01:35:38 +00:00
Owner
Copy Link

Originally created by @malxau on GitHub (May 30, 2020).

Environment

10.0.19041

Steps to reproduce

  1. Create a shortcut to a fully qualified command line executable, as in C:\Path\To\Thing.exe
  2. Explorer will default to consume the first icon from C:\Path\To\Thing.exe and display that as the shortcut icon.
  3. Execute the shortcut, and conhost will get a default icon.

Expected behavior

The icon in the conhost window will be the same one explorer found, being the first icon in the executable.

Actual behavior

When executing the shortcut, conhost.exe will enter SystemConfigurationProvider::GetSettingsFromLink with pwszAppName of "Thing.exe", call ShortcutSerialization::s_GetLinkValues to find if there's an explicit icon reference in the shortcut (there isn't), then it will call SearchPathW on "Thing.exe" to find any instance of it in %PATH%, then call PathFileExists on the shortcut title "Thing". It will never look at the original "C:\Path\To\Thing.exe", and will end up with a default icon. Note that the title value is changed in this function; on entry it is the path to the shortcut (not the target of the shortcut) and it is updated to contain the title field contained within the shortcut before calling PathFileExists.

It looks to me like s_GetLinkValues should also try to return the shortcut target (IShellLink::GetPath), and this value should be used in preference to SearchPathW. SearchPathW is really a fallback in case of a shortcut that contains a file name without a path.

Edit: Note that SearchPathW will search the current directory, so if the working directory in the shortcut (IShellLink::GetWorkingDirectory) is the parent directory of the executable, the icon will be found by conhost. This is the default behavior when creating a shortcut through the right click, New Shortcut menu in Explorer, but the working directory can be edited later without affecting the repro. Ie., Explorer won't explicitly set the icon location without the user selecting an icon.

Originally created by @malxau on GitHub (May 30, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment 10.0.19041 # Steps to reproduce 1. Create a shortcut to a fully qualified command line executable, as in C:\Path\To\Thing.exe 2. Explorer will default to consume the first icon from C:\Path\To\Thing.exe and display that as the shortcut icon. 3. Execute the shortcut, and conhost will get a default icon. # Expected behavior The icon in the conhost window will be the same one explorer found, being the first icon in the executable. # Actual behavior When executing the shortcut, conhost.exe will enter SystemConfigurationProvider::GetSettingsFromLink with pwszAppName of "Thing.exe", call ShortcutSerialization::s_GetLinkValues to find if there's an explicit icon reference in the shortcut (there isn't), then it will call SearchPathW on "Thing.exe" to find any instance of it in %PATH%, then call PathFileExists on the shortcut title "Thing". It will never look at the original "C:\Path\To\Thing.exe", and will end up with a default icon. Note that the title value is changed in this function; on entry it is the path to the shortcut (not the target of the shortcut) and it is updated to contain the title field contained within the shortcut before calling PathFileExists. It looks to me like s_GetLinkValues should also try to return the shortcut target (IShellLink::GetPath), and this value should be used in preference to SearchPathW. SearchPathW is really a fallback in case of a shortcut that contains a file name without a path. Edit: Note that SearchPathW will search the current directory, so if the working directory in the shortcut (IShellLink::GetWorkingDirectory) is the parent directory of the executable, the icon will be found by conhost. This is the default behavior when creating a shortcut through the right click, New Shortcut menu in Explorer, but the working directory can be edited later without affecting the repro. Ie., Explorer won't explicitly set the icon location without the user selecting an icon.
claunia added the Product-ConhostResolution-Fix-CommittedArea-SettingsIssue-Task labels 2026-01-31 01:35:39 +00:00
claunia commented 2026-01-31 01:35:39 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 18, 2020):

:tada:This issue was addressed in #6277, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.🎉

Handy links:

@ghost commented on GitHub (Jun 18, 2020): :tada:This issue was addressed in #6277, which has now been successfully released as `Windows Terminal Preview v1.1.1671.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1671.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8690
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?