starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add support for SGR 2 Faint #9308

New Issue
Closed
opened 2026-01-31 01:51:21 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 01:51:21 +00:00
Owner
Copy Link

Originally created by @willmcgugan on GitHub (Jun 27, 2020).

Originally assigned to: @DHowett on GitHub.

We do not support Faint text.

Original content

Description of the new feature/enhancement

Windows Terminal doesn't appear to support the dim ansi escape code (SGR 2) or italic (SGR 3). Adding support for these would I think bring WT up to feature parity with most OSX and Linux terminals.

There are other SGR escape codes that would be nice to have, but aren't as common or as useful as dim and italic.

Proposed technical implementation details (optional)

Dim strikes me as an easy one to achieve. I imagine italic would be a little trickier.

Originally created by @willmcgugan on GitHub (Jun 27, 2020). Originally assigned to: @DHowett on GitHub. We do not support Faint text. <details> <summary>Original content</summary> # Description of the new feature/enhancement Windows Terminal doesn't appear to support the *dim* ansi escape code (SGR 2) or *italic* (SGR 3). Adding support for these would I think bring WT up to feature parity with most OSX and Linux terminals. There are other SGR escape codes that would be nice to have, but aren't as common or as useful as dim and italic. # Proposed technical implementation details (optional) Dim strikes me as an easy one to achieve. I imagine italic would be a little trickier. </details>
claunia commented 2026-01-31 01:51:22 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 28, 2020):

Thanks!

This is a curious issue. We're tracking all manner of different versions of "terminal doesn't render specific attributes":

  • #109 enable bold (this is a very divisive issue), #5384 "should bold apply to ITU indexed colors", #5682 "is bold 1;39 a separate color?"
  • #2916 support parsing faint/a couple others
  • #5461 italics aren't being rendered

I just started tackling #109, despite it being divisive, and I think the infrastructure we need to build to get it off the ground (a "base + variant" system for fonts) is going to be required for this.

I'm going to close this shortly but rework all of the above issues into an amalgamated "we should support different attributes, from parsing through to rendering" issue. Does that sound good?

@DHowett commented on GitHub (Jun 28, 2020): Thanks! This is a curious issue. We're tracking all manner of different versions of "terminal doesn't render specific attributes": * #109 enable bold (this is a very divisive issue), #5384 "should bold apply to ITU indexed colors", #5682 "is bold 1;39 a separate color?" * #2916 support parsing faint/a couple others * #5461 italics aren't being rendered I just started tackling #109, despite it being divisive, and I think the infrastructure we need to build to get it off the ground (a "base + variant" system for fonts) is going to be required for this. I'm going to close this shortly but rework all of the above issues into an amalgamated "we should support different attributes, from parsing through to rendering" issue. Does that sound good?
claunia commented 2026-01-31 01:51:22 +00:00
Author
Owner
Copy Link

@willmcgugan commented on GitHub (Jun 28, 2020):

Sounds good to me 👍

@willmcgugan commented on GitHub (Jun 28, 2020): Sounds good to me 👍
claunia commented 2026-01-31 01:51:22 +00:00
Author
Owner
Copy Link

@csdvrx commented on GitHub (Jul 3, 2020):

I'm going to close this shortly but rework all of the above issues into an amalgamated "we should support different attributes, from parsing through to rendering" issue. Does that sound good?

I added #6779 which provides a test script and an expected output.

It links another issue: there is no font switching, which would be useful for mixing different fonts.

@csdvrx commented on GitHub (Jul 3, 2020): > I'm going to close this shortly but rework all of the above issues into an amalgamated "we should support different attributes, from parsing through to rendering" issue. Does that sound good? I added #6779 which provides a test script and an expected output. It links another issue: there is no font switching, which would be useful for mixing different fonts.
claunia commented 2026-01-31 01:51:22 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 9, 2020):

@DHowett I've just realised this has been assigned to you, and wanted to check exactly which parts you're working on, or planning to work on. Reason being I was about to start on the faint attribute, as a follow up to the color refactoring in PR #6853, but if you already have plans for that, I can leave it to you.

Edit: I should add that my intention was to treat the faint attribute as entirely separate from bold/bright - i.e. both can be applied at the same time. My reasoning for this is explained in issue https://github.com/microsoft/terminal/issues/2916#issuecomment-652061927.

@j4james commented on GitHub (Jul 9, 2020): @DHowett I've just realised this has been assigned to you, and wanted to check exactly which parts you're working on, or planning to work on. Reason being I was about to start on the faint attribute, as a follow up to the color refactoring in PR #6853, but if you already have plans for that, I can leave it to you. Edit: I should add that my intention was to treat the faint attribute as entirely separate from bold/bright - i.e. both can be applied at the same time. My reasoning for this is explained in issue https://github.com/microsoft/terminal/issues/2916#issuecomment-652061927.
claunia commented 2026-01-31 01:51:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 9, 2020):

@j4james it’s assigned to me for administrative reasons; I’m going to create a scenario for the various attributes impacting the display of text, and then close/rework some of the ones we already have open to fit under it. If you want to do work in this area, you’re welcome to 😄 I just may change which issue number your PR eventually closes

@DHowett commented on GitHub (Jul 9, 2020): @j4james it’s assigned to me for administrative reasons; I’m going to create a scenario for the various attributes impacting the display of text, and then close/rework some of the ones we already have open to fit under it. If you want to do work in this area, you’re welcome to :smile: I just may change which issue number your PR eventually closes
claunia commented 2026-01-31 01:51:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2020):

I've repurposed this to track Faint, and crossed out mention of Faint in #2916. Your pull request can unabashedly close this issue and drop mention of 2916.

@DHowett commented on GitHub (Jul 13, 2020): I've repurposed this to track Faint, and crossed out mention of Faint in #2916. Your pull request can unabashedly close this issue and drop mention of 2916.
claunia commented 2026-01-31 01:51:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2020):

I've filed #6879 to track "all" attributes.

@DHowett commented on GitHub (Jul 13, 2020): I've filed #6879 to track "all" attributes.
claunia commented 2026-01-31 01:51:23 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6873, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6873, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 01:51:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 21, 2020):

🎉 As of Windows Insider build 20197, this is also supported in the traditional console.

@DHowett commented on GitHub (Aug 21, 2020): 🎉 As of Windows Insider build 20197, this is also supported in the traditional console.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-VT Help Wanted Issue-Task Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9308
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?