Commits a7e3705d05 and
a4c321e492, while trying to simplify how
the FLAC_API_SUPPORTS_OGG_FLAC global variable was initialized,
inadvertently caused it to be always set to false, whether Ogg support
was compiled in or not.
This commit reverts the relevant part to how it looked in the 1.2.1
release, which is verbose but correct.
The problem was found by Robert Kausch <robert.kausch@freac.org>.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
In the flac(1) man page, fix the path to the HTML documentation. Patch
by Joshua Kwan <joshk@triplehelix.org>, taken from the Debian patch
tracker for flac 1.2.1-6 (02_doc_path.patch).
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
When a locale is in effect that does not use the point as the decimal
mark (e.g., sv_SE or de_DE, which use a comma) and a ReplayGain tag is
read for --apply-replaygain-which-is-not-lossless, the gain value was
misinterpreted (e.g., "-2.29" truncated to "-2"). This is fixed by
resetting the locale to "C" temporarily, based on Josh Coalson's fix
of the dual case (writing ReplayGain tag) in commit cda02d3.
Patch by hhaamu@gmail.com, taken from the Debian patch tracker for
flac 1.2.1-6 (13_replaygain_c_locale.patch).
http://sourceforge.net/p/flac/bugs/380/
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
test_metaflac.sh wasn't aborting when replaygain values were
incorrect because the die() function was embedded in a pipe.
set -e was added so the script exits with a non-zero exit code
when die is called in a pipe.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
The embedded awk script was using the 'lshift' function which
apparently only exists in GNU auk (gawk) and definitely does not
exist in mawk.
Thanks to Martijn van Beurden <mvanb1@gmail.com> for reporting
this issue.
Metaflac can now print all console supported characters from tags on the
screen. It also fixes metaflac to be able to import its own exports back
without non-ascii characters getting mutilated. And --no-utf8-convert
now works properly with import and export commands.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
My Valgrind doesn't run, saying it doesn't support showing more
than 50 entries of a stack trace
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
This should enable using the disable-thorough-tests,
enable-exhaustive-tests and enable-valgrind-testing
configure switches, because setting these didn't do
anything
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Change metaflac hexdump function so utf-8 decoding is only used for
filename printing and changed hex output printing to not rely only
on isprint. That function seems to return true for tabulator
control character under Windows when application isn't using C-locale.
Patch (with one minor tweak) from Janne Hyvärinen <cse@sci.fi>.
This should avoid a build error on Mac OSX where it the Mac build
tools refused to build an empty library. Problem reported by
Michael Guntsche <michael.guntsche@it-loops.com>.
The smaller patch makes the utf-8 library use ANSI codepage by
default. When frontends call the "get_utf8_argv" function it
changes Unicode conversion codepage from ANSI to UTF-8.
Patch from Janne Hyvärinen <cse@sci.fi>.
Most of the programs don't use libogg or libm directly and should not
link to them (overlinking).
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Libraries that are used internally by libFLAC(++) but are not part of
their API should be listed in pkg-config "private" clauses. Otherwise
executables that are linked dynamically against libFLAC(++) will have
unneeded direct dependencies (overlinking).
Based on a patch by Brad Smith from
https://sourceforge.net/p/flac/bugs/397/
that I updated to only include ogg if libFLAC is actually built with
ogg support.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
