Commit Graph

1366 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
3e2029a354 screenshot: Use accessor instead of modifying OM property directly 2007-09-30 10:17:31 -04:00
Chris Morgan
05070e6a3a Switch to accessor to set objectManager::sReturnTo. Fixes a fatal error due to bugs class accessing a private member of objectManager. 2007-09-28 23:00:42 -04:00
Alexander Nicolaysen Sørnes
f377690a63 Remove unused deletecomment.php 2007-09-28 21:26:17 -04:00
Chris Morgan
75e6f9dcc3 Add php5 scope keywords to the objectcManager class 2007-09-28 21:25:33 -04:00
Alexander Nicolaysen Sørnes
1e1b4a1ece Fix buglink deletion on version pages 2007-09-27 09:22:20 -04:00
Alexander Nicolaysen Sørnes
bbe286a16f application: Fix permissions 2007-09-27 09:21:49 -04:00
Alexander Nicolaysen Sørnes
2823334eed Use objectManager to delete screenshots 2007-09-27 09:21:21 -04:00
Alexander Nicolaysen Sørnes
715f3af1b3 Fix screenshot submission when an app but no version is selected 2007-09-27 09:20:41 -04:00
Alexander Nicolaysen Sørnes
53a6360ec0 Allow maintainers to modify screenshot description when processing queued items 2007-09-27 09:20:03 -04:00
Chris Morgan
b96e936ff8 Switch version::makeLicenseList() back to public since we call it from browse_downloadable.php 2007-09-26 21:56:16 -04:00
Alexander Nicolaysen Sørnes
f0a2416804 testData: Add a line break after distribution help text 2007-09-26 20:12:18 -04:00
Alexander Nicolaysen Sørnes
c8b93843d7 Fix ordering of vendors in application drop-down vendor list 2007-09-26 20:11:46 -04:00
Chris Morgan
f378e0b4b5 We can't use $aArray += $oObject to add a single object to an array, switch to $aArray[] = $oObject instead 2007-09-24 22:25:49 -04:00
Chris Morgan
e07e0f5f11 Fix 'Using $this when not in object context error' by using the same method used in Application::canEdit() and Appliction::objectGetEntries() 2007-09-24 22:09:01 -04:00
Chris Morgan
09466f59a1 Minor code formatting changes for clarity. 2007-09-24 22:08:22 -04:00
Chris Morgan
a6f76eb892 Confusion between sAction=view and sAction=display broke viewing/displaying items. Standardize on sAction=view until we can come up with a more robust way of ensuring the same issue doesn't happen again. 2007-09-24 21:35:35 -04:00
Chris Morgan
fafcbce1bd Add more php5 scope keywords to class methods. 2007-09-24 21:11:49 -04:00
Alexander Nicolaysen Sørnes
fb20a7b546 testData: add preview support 2007-09-24 21:00:05 -04:00
Alexander Nicolaysen Sørnes
2d7a93b05c objectManager: Use '===' to check for Preview requests 2007-09-24 20:04:28 -04:00
Alexander Nicolaysen Sørnes
c90d271886 testData: Fix 'Show All Tests' button 2007-09-24 19:57:23 -04:00
Alexander Nicolaysen Sørnes
c4736bf21c maintainer: Make the unit tests happy 2007-09-24 19:55:16 -04:00
Chris Morgan
561e44573d Fix error when processing bug links. Reported by Tony Lambregts. 2007-09-23 11:54:54 -04:00
Alexander Nicolaysen Sørnes
d7fc82c72f objectManager: add preview support, use it for notes 2007-09-23 11:43:32 -04:00
Alexander Nicolaysen Sørnes
4b453e1e5a version: Improve the submit test button for not-logged-in users 2007-09-20 21:30:26 -04:00
Alexander Nicolaysen Sørnes
e5d1bc1bf0 Use objectManager to submit super maintainer requests 2007-09-20 21:29:57 -04:00
Alexander Nicolaysen Sørnes
3ab41b6fca Use objectManager to submit maintainer requests 2007-09-20 21:29:00 -04:00
Alexander Nicolaysen Sørnes
fdfe3eb2d3 Fix objectGetCustomVars 2007-09-20 21:16:14 -04:00
Alexander Nicolaysen Sørnes
af87e89535 Use objectManager to display applications 2007-09-19 20:38:34 -04:00
Alexander Nicolaysen Sørnes
72a250b2b0 Use objectManager to add and edit notes 2007-09-19 20:38:17 -04:00
Alexander Nicolaysen Sørnes
a6a62a2299 Use objectManager to display versions 2007-09-19 20:37:21 -04:00
Alexander Nicolaysen Sørnes
69b14f58c7 version: urlencode the sReturnTo value when submitting test results 2007-09-19 20:36:38 -04:00
Alexander Nicolaysen Sørnes
1a91a5cdf2 Remove unused code from deleteAny.php 2007-09-19 20:31:33 -04:00
Chris Morgan
e82dc74162 Fixes for permission errors introduced by the table permission changes. 2007-09-18 22:09:57 -04:00
Chris Morgan
5c91961d12 Php5 improvements to table code. Add some accessor methods to classes so we can make class variables private. 2007-09-18 21:22:43 -04:00
Chris Morgan
e0e19c26a7 Stop script processing upon mysql error. Based on a patch by Alexander Sornes. 2007-09-18 20:51:28 -04:00
Alexander Nicolaysen Sørnes
27660a74d9 bug: Fix unqueue mails 2007-09-18 20:42:20 -04:00
Alexander Nicolaysen Sørnes
93d71f630a Prepare for viewing versions using objectManager 2007-09-18 20:38:28 -04:00
Alexander Nicolaysen Sørnes
43e3e6bebc bug: Let objectManager unqueue bug links 2007-09-17 21:28:03 -04:00
Alexander Nicolaysen Sørnes
74cf6afeb2 bug: Let objectManager delete bug links 2007-09-17 21:27:10 -04:00
Alexander Nicolaysen Srnes
09d96b79bd comment: Fix delete permissions 2007-09-17 21:25:57 -04:00
Alexander Nicolaysen Srnes
0f21daba18 Return user to the version view after submitting test data 2007-09-17 21:23:43 -04:00
Chris Morgan
f9e712382d Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Adapt the missing screenshots mail in the cron screenshots cleanup code to specify more clearly what action was taken.
2007-09-14 23:48:05 -04:00
Chris Morgan
607b130577 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Show the versions for an app if they have the same queue status.

Instead of checking whether the version is un-queued, check if it has the same
status as the application.  This is needed to allow users to edit a queued
application they have submitted.
Modify the function name to reflect the change.
2007-09-14 23:45:51 -04:00
Chris Morgan
232e889344 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
testData: Make the distribution help text more relevant. It should reflect the current situation instead of being static.
2007-09-14 23:43:57 -04:00
Chris Morgan
def14310d5 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Improve vendor help in the application editor. Fix the help to reflect the vendor/application state.
2007-09-14 23:42:51 -04:00
Chris Morgan
e963bbdfda Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Remove the vendor from keywords hack. There are no longer any entries with this data in the application queues.
2007-09-14 23:41:02 -04:00
Chris Morgan
9ac39b46e6 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Don't show addresses in the 'mail sent' messages. Just print a message saying whether it failed or not.
2007-09-14 23:38:45 -04:00
Chris Morgan
6671c7c38e Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Let objectManager add bug links.
2007-09-14 23:37:10 -04:00
Chris Morgan
b2cc871f09 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Use objectManager to create monitors.
2007-09-14 23:31:20 -04:00
Chris Morgan
d5cf2375dd Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Use objectManager to delete monitors.
2007-09-14 23:27:36 -04:00