starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-09 02:26:45 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A suspected bug of CreateThread API usage #642

New Issue
Closed
opened 2026-01-30 21:57:51 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 21:57:51 +00:00
Owner
Copy Link

Originally created by @MouriNaruto on GitHub (May 6, 2019).

First of all, I am very happy to read the source code of this project.

When I see the implementation of VtInputThread::Start() in /src/host/VtInputThread.cpp (35229a775d/src/host/VtInputThread.cpp (L160)) and found:

hThread = CreateThread(nullptr,
                           0,
                           (LPTHREAD_START_ROUTINE)VtInputThread::StaticVtInputThreadProc,
                           this,
                           0,
                           &dwThreadId);

RETURN_LAST_ERROR_IF(hThread == INVALID_HANDLE_VALUE);

And I also read the documentation of the CreateThread API (https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-createthread) and found:

If the function fails, the return value is NULL. To get extended error information, call GetLastError.

I am curious about that. Maybe this is a bug.

Kenji Mouri

Originally created by @MouriNaruto on GitHub (May 6, 2019). First of all, I am very happy to read the source code of this project. When I see the implementation of VtInputThread::Start() in /src/host/VtInputThread.cpp (https://github.com/Microsoft/Terminal/blob/35229a775d9e9908a8dfb102e01f49b494b29194/src/host/VtInputThread.cpp#L160) and found: ``` hThread = CreateThread(nullptr, 0, (LPTHREAD_START_ROUTINE)VtInputThread::StaticVtInputThreadProc, this, 0, &dwThreadId); RETURN_LAST_ERROR_IF(hThread == INVALID_HANDLE_VALUE); ``` And I also read the documentation of the CreateThread API (https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-createthread) and found: > If the function fails, **the return value is NULL**. To get extended error information, call GetLastError. I am curious about that. Maybe this is a bug. Kenji Mouri
claunia added the Help WantedProduct-ConhostIssue-BugNeeds-Tag-FixArea-Server labels 2026-01-30 21:57:51 +00:00
claunia commented 2026-01-30 21:57:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 6, 2019):

Oh, yea that might be a bug.

@zadjii-msft commented on GitHub (May 6, 2019): Oh, yea that might be a bug.
claunia commented 2026-01-30 21:57:53 +00:00
Author
Owner
Copy Link

@MouriNaruto commented on GitHub (May 6, 2019):

There are some implementations which have the same suspected bug.

PtySignalInputThread::Start() in src/host/PtySignalInputThread.cpp
35229a775d/src/host/PtySignalInputThread.cpp (L168)

@zadjii-msft

Kenji Mouri

@MouriNaruto commented on GitHub (May 6, 2019): There are some implementations which have the same suspected bug. PtySignalInputThread::Start() in src/host/PtySignalInputThread.cpp https://github.com/Microsoft/Terminal/blob/35229a775d9e9908a8dfb102e01f49b494b29194/src/host/PtySignalInputThread.cpp#L168 @zadjii-msft Kenji Mouri
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Help Wanted Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?