doc: clean up the schema (#5304)

## Summary of the Pull Request
This PR performs a number of miscellaneous clean-up tasks on our schema:
- [X] allow null for some settings
- [X] update some default values to be more useful
- [X] consistently use " instead of '
- [X] remove colorTable
- [X] provide missing description for `backgroundImageOpacity`
- [X] update cursorShape to have options match order displayed in vs code
- [X] if a setting has multiple options, provide a list of those options with a short description on each
   - this one I only did a few times
- [X] remove a little bit of ambiguity on some descriptions

## PR Checklist
Closes #5279

## Detailed Description of the Pull Request / Additional comments
Validation was performed for...
- [X] Global Settings
- [X] Profile Settings
- [x] Keybinding Actions

## Validation Steps Performed
I linked VS Code to the my version of the schema. Defined all settings from scratch in settings.json. Anytime I found something off, I updated the schema and saw if it looks right.

(cherry picked from commit 9e23ee7fd6)

doc/cascadia/SettingsSchema.md

@@ -21,6 +21,7 @@ Properties listed below affect the entire window, regardless of the profile sett
 | `tabWidthMode` | Optional | String | `equal` | Sets the width of the tabs. Possible values: `"equal"`, `"titleLength"` |
 | `wordDelimiters` | Optional | String | <code>&nbsp;&#x2f;&#x5c;&#x28;&#x29;&#x22;&#x27;&#x2d;&#x3a;&#x2c;&#x2e;&#x3b;&#x3c;&#x3e;&#x7e;&#x21;&#x40;&#x23;&#x24;&#x25;&#x5e;&#x26;&#x2a;&#x7c;&#x2b;&#x3d;&#x5b;&#x5d;&#x7b;&#x7d;&#x7e;&#x3f;│</code><br>_(`│` is `U+2502 BOX DRAWINGS LIGHT VERTICAL`)_ | Determines the delimiters used in a double click selection. |
 | `confirmCloseAllTabs` | Optional | Boolean | `true` | When set to `true` closing a window with multiple tabs open WILL require confirmation.  When set to `false` closing a window with multiple tabs open WILL NOT require confirmation. |
+| `disabledProfileSources` | Optional | Array[String] | `[]` | Disables all the dynamic profile generators in this list, preventing them from adding their profiles to the list of profiles on startup. This array can contain any combination of `Windows.Terminal.Wsl`, `Windows.Terminal.Azure`, or `Windows.Terminal.PowershellCore`. For more information, see [UsingJsonSettings.md](https://github.com/microsoft/terminal/blob/master/doc/user-docs/UsingJsonSettings.md#dynamic-profiles) |
 
 ## Profiles
 Properties listed below are specific to each unique profile.
@@ -42,7 +43,7 @@ Properties listed below are specific to each unique profile.
 | `cursorColor` | Optional | String | | Sets the cursor color of the profile. Overrides `cursorColor` set in color scheme if `colorscheme` is set. Uses hex color format: `"#rrggbb"`. |
 | `cursorHeight` | Optional | Integer | | Sets the percentage height of the cursor starting from the bottom. Only works when `cursorShape` is set to `"vintage"`. Accepts values from 25-100. |
 | `cursorShape` | Optional | String | `bar` | Sets the cursor shape for the profile. Possible values: `"vintage"` ( &#x2583; ), `"bar"` ( &#x2503; ), `"underscore"` ( &#x2581; ), `"filledBox"` ( &#x2588; ), `"emptyBox"` ( &#x25AF; ) |
-| `fontFace` | Optional | String | `Cascadia Code` | Name of the font face used in the profile. We will try to fallback to Consolas if this can't be found or is invalid. |
+| `fontFace` | Optional | String | `Cascadia Mono` | Name of the font face used in the profile. We will try to fallback to Consolas if this can't be found or is invalid. |
 | `fontSize` | Optional | Integer | `12` | Sets the font size. |
 | `foreground` | Optional | String | | Sets the foreground color of the profile. Overrides `foreground` set in color scheme if `colorscheme` is set. Uses hex color format: `#rgb` or `"#rrggbb"`. |
 | `hidden` | Optional | Boolean | `false` | If set to true, the profile will not appear in the list of profiles. This can be used to hide default profiles and dynamically generated profiles, while leaving them in your settings file. |
@@ -92,7 +93,7 @@ Properties listed below are specific to each custom key binding.
 | Property | Necessity | Type | Description |
 | -------- | ---- | ----------- | ----------- |
 | `command` | _Required_ | String | The command executed when the associated key bindings are pressed. |
-| `keys` | _Required_ | Array[String] | Defines the key combinations used to call the command. |
+| `keys` | _Required_ | Array[String] or String | Defines the key combinations used to call the command. |
 | `action` | Optional | String | Adds additional functionality to certain commands. |
 
 ### Implemented Commands and Actions

doc/cascadia/profiles.schema.json

@@ -1,7 +1,7 @@
 {
   "$id": "https://github.com/microsoft/terminal/blob/master/doc/cascadia/profiles.schema.json",
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "title": "Microsoft's Windows Terminal Settings Profile Schema'",
+  "title": "Microsoft's Windows Terminal Settings Profile Schema",
   "definitions": {
     "KeyChordSegment": {
       "pattern": "^(?<modifier>(ctrl|alt|shift)(?:\\+(ctrl|alt|shift)(?<!\\2))?(?:\\+(ctrl|alt|shift)(?<!\\2|\\3))?\\+)?(?<key>[^\\s+]|backspace|tab|enter|esc|escape|space|pgup|pageup|pgdn|pagedown|end|home|left|up|right|down|insert|delete|(?<!shift.+)(?:numpad_?[0-9]|numpad_(?:period|decimal))|numpad_(?:multiply|plus|add|minus|subtract|divide)|f[1-9]|f1[0-9]|f2[0-4]|plus)$",
@@ -18,6 +18,14 @@
       "pattern": "^(-?\\d+)?(,\\s?(-?\\d+)?)?$",
       "type": "string"
     },
+    "DynamicProfileSource": {
+      "enum": [
+        "Windows.Terminal.Wsl",
+        "Windows.Terminal.Azure",
+        "Windows.Terminal.PowershellCore"
+      ],
+      "type": "string"
+    },
     "ProfileGuid": {
       "default": "{}",
       "pattern": "^\\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\\}$",
@@ -90,7 +98,7 @@
         },
         "index": {
           "type": "integer",
-          "description": "The index of the profile in the new tab dropdown to open"
+          "description": "The index of the profile in the new tab dropdown (starting at 0)"
         }
       },
       "type": "object"
@@ -134,7 +142,7 @@
             "singleLine": {
               "type": "boolean",
               "default": false,
-              "description": "If true, newlines are removed and whitespace is maintained. If false, whitespace is removed and newlines are maintained."
+              "description": "If true, the copied content will be copied as a single line (even if there are hard line breaks present in the text). If false, newlines persist from the selected text."
             }
           }
         }
@@ -214,11 +222,11 @@
             "split": {
               "$ref": "#/definitions/SplitState",
               "default": "auto",
-              "description": "The orientation to split the pane in, either vertical (think [|]), horizontal (think [-]), or auto (splits pane based on remaining space)"
+              "description": "The orientation to split the pane in. Possible values:\n -\"auto\" (splits pane based on remaining space)\n -\"horizontal\" (think [-])\n -\"vertical\" (think [|])"
             },
             "splitMode": {
               "default": "duplicate",
-              "description": "Control how the pane splits. Only accepts `duplicate` which will duplicate the focused pane's profile into a new pane."
+              "description": "Control how the pane splits. Only accepts \"duplicate\" which will duplicate the focused pane's profile into a new pane."
             }
           }
         }
@@ -242,7 +250,7 @@
             ]
         },
         "keys": {
-          "description": "Defines the key combinations used to call the command.",
+          "description": "Defines the key combinations used to call the command. It must be composed of...\n -any number of modifiers (ctrl/alt/shift)\n -a non-modifier key",
           "oneOf": [
             {
               "$ref": "#/definitions/KeyChordSegment"
@@ -269,7 +277,7 @@
       "properties": {
         "alwaysShowTabs": {
           "default": true,
-          "description": "When set to true, tabs are always displayed. When set to false and showTabsInTitlebar is set to false, tabs only appear after opening a new tab.",
+          "description": "When set to true, tabs are always displayed. When set to false and \"showTabsInTitlebar\" is set to false, tabs only appear after opening a new tab.",
           "type": "boolean"
         },
         "copyOnSelect": {
@@ -284,7 +292,14 @@
         },
         "defaultProfile": {
           "$ref": "#/definitions/ProfileGuid",
-          "description": "Sets the default profile. Opens by clicking the '+' icon or typing the key binding assigned to 'newTab'. The guid of the desired default profile is used as the value."
+          "description": "Sets the default profile. Opens by clicking the \"+\" icon or typing the key binding assigned to \"newTab\". The \"guid\" of the desired default profile is used as the value."
+        },
+        "disabledProfileSources": {
+          "description": "Disables all the dynamic profile generators in this list, preventing them from adding their profiles to the list of profiles on startup.",
+          "items": {
+            "$ref": "#/definitions/DynamicProfileSource"
+          },
+          "type": "array"
         },
         "initialCols": {
           "default": 120,
@@ -295,7 +310,7 @@
         },
         "initialPosition": {
           "$ref": "#/definitions/Coordinates",
-          "description": "The position of the top left corner of the window upon first load. On a system with multiple displays, these coordinates are relative to the top left of the primary display. If launchMode is set to maximized, the window will be maximized on the monitor specified by those coordinates."
+          "description": "The position of the top left corner of the window upon first load. On a system with multiple displays, these coordinates are relative to the top left of the primary display. If \"launchMode\" is set to maximized, the window will be maximized on the monitor specified by those coordinates."
         },
         "initialRows": {
           "default": 30,
@@ -315,7 +330,7 @@
         },
         "rowsToScroll": {
           "default": "system",
-          "description": "The number of rows to scroll at a time with the mouse wheel. This will override the system setting if the value is not zero or 'system'.",
+          "description": "The number of rows to scroll at a time with the mouse wheel. This will override the system setting if the value is not zero or \"system\".",
           "maximum": 999,
           "minimum": 0,
           "type": ["integer", "string"]
@@ -329,7 +344,7 @@
         },
         "theme": {
           "default": "system",
-          "description": "Sets the theme of the application.",
+          "description": "Sets the theme of the application. The special value \"system\" refers to the active Windows system theme.",
           "enum": [
             "light",
             "dark",
@@ -344,17 +359,17 @@
         },
         "showTerminalTitleInTitlebar": {
           "default": true,
-          "description": "When set to true, titlebar displays the title of the selected tab. When set to false, titlebar displays 'Windows Terminal'.",
+          "description": "When set to true, titlebar displays the title of the selected tab. When set to false, titlebar displays \"Windows Terminal\".",
           "type": "boolean"
         },
         "snapToGridOnResize": {
           "default": false,
-          "description": "When set to true, the window will snap to the nearest character boundary on resize. When false, the window will resize 'smoothly'",
+          "description": "When set to true, the window will snap to the nearest character boundary on resize. When false, the window will resize smoothly",
           "type": "boolean"
         },
         "tabWidthMode": {
           "default": "equal",
-          "description": "Sets the width of the tabs.",
+          "description": "Sets the width of the tabs. Possible values include:\n -\"equal\" sizes each tab to the same width\n -\"titleLength\" sizes each tab to the length of its title",
           "enum": [
             "equal",
             "titleLength"
@@ -368,7 +383,7 @@
         },
         "confirmCloseAllTabs": {
           "default": true,
-          "description": " When set to `true` closing a window with multiple tabs open WILL require confirmation.  When set to `false` closing a window with multiple tabs open WILL NOT require confirmation.",
+          "description": "When set to \"true\" closing a window with multiple tabs open will require confirmation.  When set to \"false\", the confirmation dialog will not appear.",
           "type":"boolean"
         }
       },
@@ -401,11 +416,11 @@
         "background": {
           "$ref": "#/definitions/Color",
           "default": "#0c0c0c",
-          "description": "Sets the background color of the profile. Overrides background set in color scheme if colorscheme is set. Uses hex color format: \"#rrggbb\".",
+          "description": "Sets the background color of the text. Overrides \"background\" from the color scheme. Uses hex color format: \"#rrggbb\".",
           "type": ["string", "null"]
         },
         "backgroundImage": {
-          "description": "Sets the file location of the Image to draw over the window background.",
+          "description": "Sets the file location of the image to draw over the window background.",
           "type": ["string", "null"]
         },
         "backgroundImageAlignment": {
@@ -421,12 +436,14 @@
             "topLeft",
             "topRight"
           ],
+          "description": "Sets how the background image aligns to the boundaries of the window. Possible values: \"center\", \"left\", \"top\", \"right\", \"bottom\", \"topLeft\", \"topRight\", \"bottomLeft\", \"bottomRight\"",
           "type": "string"
         },
         "backgroundImageOpacity": {
-          "description": "(Not in SettingsSchema.md)",
-          "maximum": 1,
-          "minimum": 0,
+          "default": 1.0,
+          "description": "Sets the transparency of the background image. Accepts floating point values from 0-1.",
+          "maximum": 1.0,
+          "minimum": 0.0,
           "type": "number"
         },
         "backgroundImageStretchMode": {
@@ -442,7 +459,7 @@
         },
         "closeOnExit": {
           "default": "graceful",
-          "description": "Sets how the profile reacts to termination or failure to launch. Possible values: \"graceful\" (close when exit is typed or the process exits normally), \"always\" (always close) and \"never\" (never close). true and false are accepted as synonyms for \"graceful\" and \"never\" respectively.",
+          "description": "Sets how the profile reacts to termination or failure to launch. Possible values:\n -\"graceful\" (close when exit is typed or the process exits normally)\n -\"always\" (always close)\n -\"never\" (never close).\ntrue and false are accepted as synonyms for \"graceful\" and \"never\" respectively.",
           "oneOf": [
             {
               "enum": [
@@ -462,109 +479,27 @@
           "description": "Name of the terminal color scheme to use. Color schemes are defined under \"schemes\".",
           "type": "string"
         },
-        "colorTable": {
-          "description": "Array of colors used in the profile if colorscheme is not set. Colors use hex color format: \"#rrggbb\". Ordering is as follows: [black, red, green, yellow, blue, magenta, cyan, white, bright black, bright red, bright green, bright yellow, bright blue, bright magenta, bright cyan, bright white]",
-          "items": {
-            "additionalProperties": false,
-            "properties": {
-              "background": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the background color of the color table."
-              },
-              "black": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI black."
-              },
-              "blue": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI blue."
-              },
-              "brightBlack": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright black."
-              },
-              "brightBlue": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright blue."
-              },
-              "brightCyan": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright cyan."
-              },
-              "brightGreen": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright green."
-              },
-              "brightPurple": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright purple."
-              },
-              "brightRed": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright red."
-              },
-              "brightWhite": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright white."
-              },
-              "brightYellow": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI bright yellow."
-              },
-              "cyan": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI cyan."
-              },
-              "foreground": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the foreground color of the color table."
-              },
-              "green": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI green."
-              },
-              "purple": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI purple."
-              },
-              "red": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI red."
-              },
-              "white": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI white."
-              },
-              "yellow": {
-                "$ref": "#/definitions/Color",
-                "description": "Sets the color used as ANSI yellow."
-              }
-            },
-            "type": "object"
-          },
-          "type": "array"
-        },
         "commandline": {
           "description": "Executable used in the profile.",
           "type": "string"
         },
-        "connectionType": {
-          "$ref": "#/definitions/ProfileGuid",
-          "description": "A GUID reference to a connection type. Currently undocumented as of 0.3, this is used for Azure Cloud Shell"
-        },
         "cursorColor": {
-          "$ref": "#/definitions/Color",
-          "description": "Sets the cursor color of the profile. Overrides cursor color set in color scheme if colorscheme is set. Uses hex color format: \"#rrggbb\"."
+          "oneOf": [
+            { "$ref": "#/definitions/Color" },
+            {"type": "null"}
+          ],
+          "description": "Sets the color of the cursor. Overrides the cursor color from the color scheme. Uses hex color format: \"#rrggbb\"."
         },
         "cursorHeight": {
           "description": "Sets the percentage height of the cursor starting from the bottom. Only works when cursorShape is set to \"vintage\". Accepts values from 25-100.",
           "maximum": 100,
           "minimum": 25,
-          "type": ["integer","null"]
+          "type": ["integer","null"],
+          "default": 25
         },
         "cursorShape": {
           "default": "bar",
-          "description": "Sets the cursor shape for the profile. Possible values: \"vintage\" ( ▃ ), \"bar\" ( ┃, default ), \"underscore\" ( ▁ ), \"filledBox\" ( █ ), \"emptyBox\" ( ▯ )",
+          "description": "Sets the shape of the cursor. Possible values:\n -\"bar\" ( ┃, default )\n -\"emptyBox\" ( ▯ )\n -\"filledBox\" ( █ )\n -\"underscore\" ( ▁ )\n -\"vintage\" ( ▃ )",
           "enum": [
             "bar",
             "emptyBox",
@@ -579,20 +514,20 @@
           "type": "boolean"
         },
         "fontFace": {
-          "default": "Cascadia Code",
+          "default": "Cascadia Mono",
           "description": "Name of the font face used in the profile.",
           "type": "string"
         },
         "fontSize": {
           "default": 12,
-          "description": "Sets the font size.",
+          "description": "Size of the font in points.",
           "minimum": 1,
           "type": "integer"
         },
         "foreground": {
           "$ref": "#/definitions/Color",
           "default": "#cccccc",
-          "description": "Sets the foreground color of the profile. Overrides foreground set in color scheme if colorscheme is set. Uses hex color format: \"#rrggbb\".",
+          "description": "Sets the text color. Overrides \"foreground\" from the color scheme. Uses hex color format: \"#rrggbb\".",
           "type": ["string", "null"]
         },
         "guid": {
@@ -621,7 +556,7 @@
         },
         "padding": {
           "default": "8, 8, 8, 8",
-          "description": "Sets the padding around the text within the window. Can have three different formats: \"#\" sets the same padding for all sides, \"#, #\" sets the same padding for left-right and top-bottom, and \"#, #, #, #\" sets the padding individually for left, top, right, and bottom.",
+          "description": "Sets the padding around the text within the window. Can have three different formats:\n -\"#\" sets the same padding for all sides \n -\"#, #\" sets the same padding for left-right and top-bottom\n -\"#, #, #, #\" sets the padding individually for left, top, right, and bottom.",
           "pattern": "^-?[0-9]+(\\.[0-9]+)?( *, *-?[0-9]+(\\.[0-9]+)?|( *, *-?[0-9]+(\\.[0-9]+)?){3})?$",
           "type": "string"
         },
@@ -635,8 +570,11 @@
           "type": "string"
         },
         "selectionBackground": {
-          "$ref": "#/definitions/Color",
-          "description": "Sets the selection background color of the profile. Overrides selection background set in color scheme if colorscheme is set. Uses hex color format: \"#rrggbb\"."
+          "oneOf": [
+            {"$ref": "#/definitions/Color"},
+            { "type": "null" }
+          ],
+          "description": "Sets the background color of selected text. Overrides selectionBackground set in the color scheme. Uses hex color format: \"#rrggbb\"."
         },
         "snapOnInput": {
           "default": true,
@@ -653,7 +591,8 @@
         },
         "suppressApplicationTitle": {
           "description": "When set to true, tabTitle overrides the default title of the tab and any title change messages from the application will be suppressed. When set to false, tabTitle behaves as normal.",
-          "type": "boolean"
+          "type": "boolean",
+          "default": false
         },
         "tabTitle": {
           "description": "If set, will replace the name as the title to pass to the shell on startup. Some shells (like bash) may choose to ignore this initial value, while others (cmd, powershell) may use this value over the lifetime of the application.",

res/README.md

@@ -17,5 +17,5 @@ Please consult the [license](https://raw.githubusercontent.com/microsoft/cascadi
 
 ### Fonts Included
 
-* Cascadia Code
+* Cascadia Code, Cascadia Mono
    * from microsoft/cascadia-code@d733599504811e8f3969de20368817d20e162dba

src/cascadia/CascadiaPackage/Package.appxmanifest

@@ -74,6 +74,7 @@
     <uap7:Extension Category="windows.sharedFonts">
       <uap7:SharedFonts>
         <uap4:Font File="Cascadia.ttf" />
+        <uap4:Font File="CascadiaMono.ttf" />
       </uap7:SharedFonts>
     </uap7:Extension>
   </Extensions>

src/cascadia/CascadiaResources.build.items

@@ -11,6 +11,10 @@
       <DeploymentContent>true</DeploymentContent>
       <Link>%(RecursiveDir)%(FileName)%(Extension)</Link>
     </Content>
+    <Content Include="$(OpenConsoleDir)res\CascadiaMono.ttf" Condition="'$(WindowsTerminalReleaseBuild)'=='true'">
+      <DeploymentContent>true</DeploymentContent>
+      <Link>%(RecursiveDir)%(FileName)%(Extension)</Link>
+    </Content>
     <!-- Profile Icons -->
     <Content Include="$(OpenConsoleDir)src\cascadia\CascadiaPackage\ProfileIcons\**\*">
       <DeploymentContent>true</DeploymentContent>

src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp

@@ -76,6 +76,8 @@ namespace TerminalAppLocalTests
 
         TEST_METHOD(ValidateKeybindingsWarnings);
 
+        TEST_METHOD(ValidateLegacyGlobalsWarning);
+
         TEST_CLASS_SETUP(ClassSetup)
         {
             InitializeJsonReader();
@@ -2225,4 +2227,40 @@ namespace TerminalAppLocalTests
         VERIFY_ARE_EQUAL(::TerminalApp::SettingsLoadWarnings::MissingRequiredParameter, settings->_warnings.at(2));
         VERIFY_ARE_EQUAL(::TerminalApp::SettingsLoadWarnings::MissingRequiredParameter, settings->_warnings.at(3));
     }
+
+    void SettingsTests::ValidateLegacyGlobalsWarning()
+    {
+        const std::string badSettings{ R"(
+        {
+            "globals": {},
+            "defaultProfile": "{6239a42c-2222-49a3-80bd-e8fdd045185c}",
+            "profiles": [
+                {
+                    "name" : "profile0",
+                    "guid": "{6239a42c-2222-49a3-80bd-e8fdd045185c}"
+                },
+                {
+                    "name" : "profile1",
+                    "guid": "{6239a42c-3333-49a3-80bd-e8fdd045185c}"
+                }
+            ],
+            "keybindings": []
+        })" };
+
+        // Create the default settings
+        CascadiaSettings settings;
+        settings._ParseJsonString(DefaultJson, true);
+        settings.LayerJson(settings._defaultSettings);
+
+        settings._ValidateNoGlobalsKey();
+        VERIFY_ARE_EQUAL(0u, settings._warnings.size());
+
+        // Now layer on the user's settings
+        settings._ParseJsonString(badSettings, false);
+        settings.LayerJson(settings._userSettings);
+
+        settings._ValidateNoGlobalsKey();
+        VERIFY_ARE_EQUAL(1u, settings._warnings.size());
+        VERIFY_ARE_EQUAL(::TerminalApp::SettingsLoadWarnings::LegacyGlobalsProperty, settings._warnings.at(0));
+    }
 }

src/cascadia/TerminalApp/AppLogic.cpp

@@ -35,7 +35,8 @@ static const std::array<std::wstring_view, static_cast<uint32_t>(SettingsLoadWar
     USES_RESOURCE(L"InvalidIcon"),
     USES_RESOURCE(L"AtLeastOneKeybindingWarning"),
     USES_RESOURCE(L"TooManyKeysForChord"),
-    USES_RESOURCE(L"MissingRequiredParameter")
+    USES_RESOURCE(L"MissingRequiredParameter"),
+    USES_RESOURCE(L"LegacyGlobalsProperty")
 };
 static const std::array<std::wstring_view, static_cast<uint32_t>(SettingsLoadErrors::ERRORS_SIZE)> settingsLoadErrorsLabels {
     USES_RESOURCE(L"NoProfilesText"),
@@ -391,6 +392,27 @@ namespace winrt::TerminalApp::implementation
             if (!warningText.empty())
             {
                 warningsTextBlock.Inlines().Append(_BuildErrorRun(warningText, ::winrt::Windows::UI::Xaml::Application::Current().as<::winrt::TerminalApp::App>().Resources()));
+
+                // The "LegacyGlobalsProperty" warning is special - it has a URL
+                // that goes with it. So we need to manually construct a
+                // Hyperlink and insert it along with the warning text.
+                if (warning == SettingsLoadWarnings::LegacyGlobalsProperty)
+                {
+                    // Add the URL here too
+                    const auto legacyGlobalsLinkLabel = RS_(L"LegacyGlobalsPropertyHrefLabel");
+                    const auto legacyGlobalsLinkUriValue = RS_(L"LegacyGlobalsPropertyHrefUrl");
+
+                    winrt::Windows::UI::Xaml::Documents::Run legacyGlobalsLinkText;
+                    winrt::Windows::UI::Xaml::Documents::Hyperlink legacyGlobalsLink;
+                    winrt::Windows::Foundation::Uri legacyGlobalsLinkUri{ legacyGlobalsLinkUriValue };
+
+                    legacyGlobalsLinkText.Text(legacyGlobalsLinkLabel);
+                    legacyGlobalsLink.NavigateUri(legacyGlobalsLinkUri);
+                    legacyGlobalsLink.Inlines().Append(legacyGlobalsLinkText);
+
+                    warningsTextBlock.Inlines().Append(legacyGlobalsLink);
+                }
+
                 warningsTextBlock.Inlines().Append(Documents::LineBreak{});
             }
         }

src/cascadia/TerminalApp/CascadiaSettings.cpp

@@ -211,6 +211,8 @@ void CascadiaSettings::_ValidateSettings()
     // warning if an action didn't have a required arg.
     // This will also catch other keybinding warnings, like from GH#4239
     _ValidateKeybindings();
+
+    _ValidateNoGlobalsKey();
 }
 
 // Method Description:
@@ -674,6 +676,25 @@ void CascadiaSettings::_ValidateKeybindings()
     }
 }
 
+// Method Description:
+// - Checks for the presence of the legacy "globals" key in the user's
+//   settings.json. If this key is present, then they've probably got a pre-0.11
+//   settings file that won't work as expected anymore. We should warn them
+//   about that.
+// Arguments:
+// - <none>
+// Return Value:
+// - <none>
+// - Appends a SettingsLoadWarnings::LegacyGlobalsProperty to our list of warnings if
+//   we find any invalid background images.
+void CascadiaSettings::_ValidateNoGlobalsKey()
+{
+    if (auto oldGlobalsProperty{ _userSettings["globals"] })
+    {
+        _warnings.push_back(::TerminalApp::SettingsLoadWarnings::LegacyGlobalsProperty);
+    }
+}
+
 // Method Description
 // - Replaces known tokens DEFAULT_PROFILE, PRODUCT and VERSION in the settings template
 //   with their expected values. DEFAULT_PROFILE is updated to match PowerShell Core's GUID

src/cascadia/TerminalApp/CascadiaSettings.h

@@ -119,6 +119,7 @@ private:
     void _ValidateAllSchemesExist();
     void _ValidateMediaResources();
     void _ValidateKeybindings();
+    void _ValidateNoGlobalsKey();
 
     friend class TerminalAppLocalTests::SettingsTests;
     friend class TerminalAppLocalTests::ProfileTests;

src/cascadia/TerminalApp/Resources/en-US/Resources.resw

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
-    Microsoft ResX Schema 
-    
+  <!--
+    Microsoft ResX Schema
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-    
+
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -187,6 +187,17 @@
     <value>&#x2022; Found a keybinding that was missing a required parameter value. This keybinding will be ignored.</value>
     <comment>{Locked="&#x2022;"} This glyph is a bullet, used in a bulleted list.</comment>
   </data>
+  <data name="LegacyGlobalsProperty" xml:space="preserve">
+    <value>The "globals" property is deprecated - your settings might need updating. </value>
+    <comment>{Locked="\"globals\""} </comment>
+  </data>
+  <data name="LegacyGlobalsPropertyHrefUrl" xml:space="preserve">
+    <value>https://go.microsoft.com/fwlink/?linkid=2128258</value>
+    <comment>{Locked}This is a FWLink, so it will be localized with the fwlink tool</comment>
+  </data>
+  <data name="LegacyGlobalsPropertyHrefLabel" xml:space="preserve">
+    <value>For more info, see this web page.</value>
+  </data>
   <data name="CmdCommandArgDesc" xml:space="preserve">
     <value>An optional command, with arguments, to be spawned in the new tab or pane</value>
   </data>

src/cascadia/TerminalApp/TerminalPage.cpp

@@ -76,7 +76,7 @@ namespace winrt::TerminalApp::implementation
             // Xaml tries to send a drag visual (to wit: a screenshot) to the drag hosting process,
             // but that process is running at a different IL than us.
             // For now, we're disabling elevated drag.
-            isElevated = ::winrt::Windows::UI::Xaml::Application::Current().as<::winrt::TerminalApp::App>().Logic().IsUwp();
+            isElevated = ::winrt::Windows::UI::Xaml::Application::Current().as<::winrt::TerminalApp::App>().Logic().IsElevated();
         }
         CATCH_LOG();
 

src/cascadia/TerminalApp/TerminalWarnings.h

@@ -29,6 +29,7 @@ namespace TerminalApp
         AtLeastOneKeybindingWarning = 5,
         TooManyKeysForChord = 6,
         MissingRequiredParameter = 7,
+        LegacyGlobalsProperty = 8,
         WARNINGS_SIZE // IMPORTANT: This MUST be the last value in this enum. It's an unused placeholder.
     };
 

src/cascadia/TerminalApp/defaults-universal.json

@@ -37,7 +37,7 @@
             "colorScheme": "Vintage",
             "cursorColor": "#FFFFFF",
             "cursorShape": "bar",
-            "fontFace": "Cascadia Code",
+            "fontFace": "Cascadia Mono",
             "icon": "ms-appx:///ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.png",
             "padding": "8, 8, 8, 8",
             "snapOnInput": true,

src/cascadia/TerminalApp/defaults.json

@@ -35,7 +35,7 @@
             "antialiasingMode": "grayscale",
             "closeOnExit": "graceful",
             "cursorShape": "bar",
-            "fontFace": "Cascadia Code",
+            "fontFace": "Cascadia Mono",
             "fontSize": 12,
             "hidden": false,
             "historySize": 9001,
@@ -53,7 +53,7 @@
             "antialiasingMode": "grayscale",
             "closeOnExit": "graceful",
             "cursorShape": "bar",
-            "fontFace": "Cascadia Code",
+            "fontFace": "Cascadia Mono",
             "fontSize": 12,
             "hidden": false,
             "historySize": 9001,
@@ -225,7 +225,7 @@
         },
         {
             "name": "Tango Dark",
-            "foreground": "#FFFFFF",
+            "foreground": "#D3D7CF",
             "background": "#000000",
             "cursorColor": "#FFFFFF",
             "black": "#000000",
@@ -247,7 +247,7 @@
         },
         {
             "name": "Tango Light",
-            "foreground": "#000000",
+            "foreground": "#555753",
             "background": "#FFFFFF",
             "cursorColor": "#000000",
             "black": "#000000",

src/cascadia/TerminalCore/terminalrenderdata.cpp

@@ -59,8 +59,8 @@ const COLORREF Terminal::GetBackgroundColor(const TextAttribute& attr) const noe
 {
     const auto bgColor = attr.CalculateRgbBackground({ _colorTable.data(), _colorTable.size() }, _defaultFg, _defaultBg);
     // We only care about alpha for the default BG (which enables acrylic)
-    // If the bg isn't the default bg color, then make it fully opaque.
-    if (!attr.BackgroundIsDefault())
+    // If the bg isn't the default bg color, or reverse video is enabled, make it fully opaque.
+    if (!attr.BackgroundIsDefault() || WI_IsFlagSet(attr.GetMetaAttributes(), COMMON_LVB_REVERSE_VIDEO))
     {
         return 0xff000000 | bgColor;
     }

src/cascadia/WindowsTerminal/main.cpp

@@ -88,6 +88,13 @@ int __stdcall wWinMain(HINSTANCE, HINSTANCE, LPWSTR, int)
         TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES),
         TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance));
 
+    // If Terminal is spawned by a shortcut that requests that it run in a new process group
+    // while attached to a console session, that request is nonsense. That request will, however,
+    // cause WT to start with Ctrl-C disabled. This wouldn't matter, because it's a Windows-subsystem
+    // application. Unfortunately, that state is heritable. In short, if you start WT using cmd in
+    // a weird way, ^C stops working _inside_ the terminal. Mad.
+    SetConsoleCtrlHandler(NULL, FALSE);
+
     // Block the user from starting if they launched the incorrect architecture version of the project.
     // This should only be applicable to developer versions. The package installation process
     // should choose and install the correct one from the bundle.

src/common.build.pre.props

@@ -88,6 +88,7 @@
       <MinimalRebuild>false</MinimalRebuild>
       <RuntimeTypeInfo>false</RuntimeTypeInfo>
       <AdditionalOptions>/std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
+      <ControlFlowGuard>Guard</ControlFlowGuard>
     </ClCompile>
     <ResourceCompile>
       <PreprocessorDefinitions>EXTERNAL_BUILD;_UNICODE;UNICODE;%(PreprocessorDefinitions)</PreprocessorDefinitions>

src/inc/DefaultSettings.h

@@ -30,7 +30,7 @@ constexpr short DEFAULT_HISTORY_SIZE = 9001;
 #pragma warning(push)
 #pragma warning(disable : 26426)
 // TODO GH 2674, don't disable this warning, move to std::wstring_view or something like that.
-const std::wstring DEFAULT_FONT_FACE{ L"Cascadia Code" };
+const std::wstring DEFAULT_FONT_FACE{ L"Cascadia Mono" };
 constexpr int DEFAULT_FONT_SIZE = 12;
 
 constexpr int DEFAULT_ROWS = 30;

src/renderer/dx/DxRenderer.cpp

@@ -885,21 +885,26 @@ try
 {
     RETURN_HR_IF(E_NOT_VALID_STATE, _isPainting); // invalid to start a paint while painting.
 
-    // If retro terminal effects are on, we must invalidate everything for them to draw correctly.
-    // Yes, this will further impact the performance of retro terminal effects.
-    // But we're talking about running the entire display pipeline through a shader for
-    // cosmetic effect, so performance isn't likely the top concern with this feature.
-    if (_retroTerminalEffects)
-    {
-        _invalidMap.set_all();
-    }
+    //// If retro terminal effects are on, we must invalidate everything for them to draw correctly.
+    //// Yes, this will further impact the performance of retro terminal effects.
+    //// But we're talking about running the entire display pipeline through a shader for
+    //// cosmetic effect, so performance isn't likely the top concern with this feature.
+    //if (_retroTerminalEffects)
+    //{
+    //    _invalidMap.set_all();
+    //}
 
-    // If we're doing High DPI, we must invalidate everything for it to draw correctly.
-    // TODO: GH: 5320 - Remove implicit DPI scaling in D2D target to enable pixel perfect High DPI
-    if (_scale != 1.0f)
-    {
-        _invalidMap.set_all();
-    }
+    //// If we're doing High DPI, we must invalidate everything for it to draw correctly.
+    //// TODO: GH: 5320 - Remove implicit DPI scaling in D2D target to enable pixel perfect High DPI
+    //if (_scale != 1.0f)
+    //{
+    //    _invalidMap.set_all();
+    //}
+
+    // TODO: GH: 778, 5345 - There are too many issues with incremental rendering for 1.0. This disables it by going back
+    // to redrawing everything.
+    // The above lines are left in and commented out for when we turn this back on post 1.0.
+    _invalidMap.set_all();
 
     if (TraceLoggingProviderEnabled(g_hDxRenderProvider, WINEVENT_LEVEL_VERBOSE, 0))
     {

src/renderer/vt/VtSequences.cpp

@@ -195,7 +195,7 @@ using namespace Microsoft::Console::Render;
 // - S_OK if we succeeded, else an appropriate HRESULT for failing to allocate or write.
 [[nodiscard]] HRESULT VtEngine::_SetGraphicsBoldness(const bool isBold) noexcept
 {
-    const std::string fmt = isBold ? "\x1b[1m" : "\x1b[22m";
+    const std::string_view fmt = isBold ? "\x1b[1m" : "\x1b[22m";
     return _Write(fmt);
 }
 
@@ -275,7 +275,7 @@ using namespace Microsoft::Console::Render;
 // - S_OK if we succeeded, else an appropriate HRESULT for failing to allocate or write.
 [[nodiscard]] HRESULT VtEngine::_SetGraphicsRenditionDefaultColor(const bool fIsForeground) noexcept
 {
-    const std::string fmt = fIsForeground ? ("\x1b[39m") : ("\x1b[49m");
+    const std::string_view fmt = fIsForeground ? ("\x1b[39m") : ("\x1b[49m");
 
     return _Write(fmt);
 }

src/terminal/adapter/InteractDispatch.cpp

@@ -46,8 +46,9 @@ bool InteractDispatch::WriteInput(std::deque<std::unique_ptr<IInputEvent>>& inpu
 // True if handled successfully. False otherwise.
 bool InteractDispatch::WriteCtrlC()
 {
-    KeyEvent key = KeyEvent(true, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
-    return _pConApi->PrivateWriteConsoleControlInput(key);
+    KeyEvent keyDown = KeyEvent(true, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
+    KeyEvent keyUp = KeyEvent(false, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
+    return _pConApi->PrivateWriteConsoleControlInput(keyDown) && _pConApi->PrivateWriteConsoleControlInput(keyUp);
 }
 
 // Method Description:

src/terminal/parser/ut_parser/InputEngineTest.cpp

@@ -337,9 +337,11 @@ bool TestInteractDispatch::WriteInput(_In_ std::deque<std::unique_ptr<IInputEven
 bool TestInteractDispatch::WriteCtrlC()
 {
     VERIFY_IS_TRUE(_testState->_expectSendCtrlC);
-    KeyEvent key = KeyEvent(true, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
+    KeyEvent keyDown = KeyEvent(true, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
+    KeyEvent keyUp = KeyEvent(false, 1, 'C', 0, UNICODE_ETX, LEFT_CTRL_PRESSED);
     std::deque<std::unique_ptr<IInputEvent>> inputEvents;
-    inputEvents.push_back(std::make_unique<KeyEvent>(key));
+    inputEvents.push_back(std::make_unique<KeyEvent>(keyDown));
+    inputEvents.push_back(std::make_unique<KeyEvent>(keyUp));
     return WriteInput(inputEvents);
 }
 

src/tools/ColorTool/schemes/tango_dark.itermcolors

@@ -196,11 +196,11 @@
         <key>Foreground Color</key>
         <dict>
             <key>Blue Component</key>
-            <string>1</string>
+            <string>0.8117647</string>
             <key>Green Component</key>
-            <string>1</string>
+            <string>0.8431373</string>
             <key>Red Component</key>
-            <string>1</string>
+            <string>0.827451</string>
         </dict>
         <key>Selected Text Color</key>
         <dict>

src/tools/ColorTool/schemes/tango_light.itermcolors

@@ -196,11 +196,11 @@
         <key>Foreground Color</key>
         <dict>
             <key>Blue Component</key>
-            <string>0</string>
+            <string>0.3254902</string>
             <key>Green Component</key>
-            <string>0</string>
+            <string>0.3411765</string>
             <key>Red Component</key>
-            <string>0</string>
+            <string>0.3333333</string>
         </dict>
         <key>Selected Text Color</key>
         <dict>