starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.18] Defterm was only busted on my machine #19766

New Issue
Closed
opened 2026-01-31 06:53:00 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:53:00 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 26, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Handoff fails, and then we open an empty terminal window (yknow, the kind with 0 tabs).

Repros back to at least 52171d2da

Attempted bisect
  • ❌ 2e3d5e658 (HEAD -> main, origin/main) Rewrite AtlasEngine to allow arbitrary overhangs
  • ❔ 405fb5120 Fix AppInitialized latency metric
  • ❔ e413a4148 Prevent crash when VTParameters::subspan is out of range
  • ❔ 4ebc383cb A hypothetical fix for hidden windows
  • ❔ fea6eeddf Disable the context menu command inside a zipped folder
  • ❔ adbe4a0d0 Fix missing call to UpdateViewport::UpdateViewport during tearout
  • ❔ 7e9f09f49 A very sensible Pane refactoring
  • ❔ 06dc975a0 Switch to function pointers
  • ❔ def3742a2 Fix focus issue when profile selected from nested menu entry
  • ❔ 5ed3c76dc Remove IsUwp, RunAsUwp, defaults-universal and all fallout
  • ❔ e491141bd Remove the window thread from the list of threads before nulling the AppHost
  • ❔ 0d1540bbd Add buttons for selecting commands, output to context menu
  • ❔ 2cfd73d81 Enable WINRT_LEAN_AND_MEAN
  • ❔ ee0530737 Also do the VisualState dance on the tab item
  • ❔ 478834756 Make sure the command palette isn't null
  • ❔ 210414e5a (origin/1.17) Default to XamlRoot when unable to find focused object
  • ❔ 2aefb3035 Remove a 1px gap under the tabs only visible at >150%
  • ❔ ffda8c4a9 Add automation heading level 1 to fix about dialog
  • ❔ 2fd33ba51 unpackaged: allow building an unpackaged distribution from layout
  • ❔ 2c165438e Add a warning when a proportional font is selected
  • ❔ 0e86ce559 Add the ability to select a whole command (or its output)
  • ❔ 35b9e7557 Avoid animations during startup
  • ❔ da0a6d468 Lazy load CommandPalette and AboutDialog
  • ❔ c2dd6143a Fix Peasant::ActivateWindow being called with an all 0 GUID
  • ❔ 27bcf7e41 Add subtext to why Always show tabs is not toggleable in SUI.
  • ❔ 2c16e7c07 Respect the startup info state initially passed to wt via ShellExecute
  • ❔ 1825ca104 fix not updating the nav view when add/removing profiles
  • ❔ e106c095a Enable ctrl+shift to run terminal elevated from context menu
  • ❌ 52171d2da Update to MUX 2.8.3
  • ❔ 9b960bc88 Fix reordering tabs mysteriously shuffling the actual backing tabs
  • ❔ 1d354d0f5 Fix a hang when writing wide glyphs into a 1 column terminal
  • ❔ eb725e999 fix: WpfTerminalControl allow Connection set to null
  • ❔ 19069e03b A more efficient copy assignment operator for Pane.LayoutSizeNode
  • ❔ (👀) 21464fe41 Manually hide our DesktopWindowXamlSource
  • ❌ 789b0b065 Actually use the persisted position with centerOnLaunch:true
  • ❔ 72d0566fa (dev/migrie/b/mux-2.8.l3) Back off between attempts to start the tests
  • ❔ f671f065b Register the GetWindowLayoutRequested handler only when ready
  • ❔ 10bdadffb Skip generating a profile for rancher-desktop
  • ❔ 56d451ded Support environment variables in the settings
  • ❔ 508adbb1e Send a KeyUp sequence only once a key has been released
  • ❔ b4f65030e Fix re-persisting the new legacy themes
  • ❔ 90bbd2927 Helix: Decode HTML entities in the test comment fiel
  • ❔ ea44375f6 Check for updates automatically (but don't install)
  • ❔ 7fbd3be8c Only try to hand off to ConhostV1 if building for Windows
  • ❔ de09671d8 wpf: Bump the history length to 9001 instead of 1000
  • ❔ c7498a426 PGO: Update the Helix payload to rely on the unpackaged distribution
  • ❔ 083fc647b Revert the revert of "Hide the window until we're finished with initialization"
  • ❔ 6f8ef5867 Add support for running the Terminal without any windows
  • ❔ fe66ba5f5 Add "legacy" themes
  • ❔ e73362d45 Respect the codepage stored in .LNK files in conhost
  • ❔ a98a0cf2c Stop the beef when you hover off a hyperlink
  • ❔ 5db8af627 Return success if ReadCharacterInput read >0 characters
  • ❔ 5f7092049 When unpackaged, isolate the monarch by the install path
  • ❌ 62448969b Upgrade clang-format to 15.0.7
  • ❔ ecb5e37a7 Use new row primitives for ResizeTraditional
  • ❔ aea0477bd Filter out control characters that don't do anything
  • ❔ 06526cac0 Remove our dependency on any CRT--AppX or forwarders
  • ❔ 9dfdf2afa Introduce til::linear_flat_set
  • ❔ 2a839d8c5 Fix accuracy bugs around float/double/int conversions
  • ❔ da995a014 Enable holding ctrl to open the Terminal elevated from Fil
  • ❔ 47a17cf2d Replace statics in headers with inline constants
  • ❔ c0f14567f Use DIPs for the window bounds when tearing out
  • ❔ 5de1fd9a7 Introduce til::generational - a struct comparison helper
  • ❔ 17cf44fa7 Upgrade to MUX 2.8
  • ❔ 06174a9cb Format URLs for display when we show the tooltip
  • ❔ 0656afcf1 Expose hyperlink attributes in PaintBufferGridLines
  • ❔ 0d38d1729 Add a simple tool to test rendering functionality
  • ❔ 7ddd98de0 Fix warnings in til for an upcoming version of MSVC
  • ❔ 0105807be Add pre-build PowerShell version check
  • ❔ e6a3fa8d4 Add "portable mode", where settings load from the install path
  • ❔ bbd4d1b1e Fix a crash in the rclick context menu
  • ❔ 984b03ca3 [SPEC] Add a lightweight spec for Portable Mode
  • ❔ 7b0aca444 Enable tearing out tabs to create new windows
  • ❔ dd63a0590 Add support for an unpackaged distribution of Terminal
  • ❔ fc9580253 Merge the LineFeed functionality into AdaptDispatch
  • ❔ da3a33f3b Minor cleanups after #14745
  • ❔ 9514c1191 Enable dragging tabs between windows
  • ❔ 17a5b7733 Add support for moving panes and tabs between windows
  • ❔ 34aa6aa0d Update DECSC/DECRC to match the newer DEC terminals
  • ❔ c7816fdb0 Add flexible virtualization rules for HKCU\Console\Startup
  • ❔ d9efdae98 Fix font size of HTML clipboard contents
  • ❔ c4d029829 Add a second way of detecting whether DefTerm is available
  • ❌ f20cd3a9d Add an efficient text stream write function
  • ❔ f5e9e8ea7 Consolidate our MSIX distribution back down to one package

OKAY I think this has got to be something unique to my machine.

Originally created by @zadjii-msft on GitHub (Apr 26, 2023). Originally assigned to: @zadjii-msft on GitHub. Handoff fails, and then we open an empty terminal window (yknow, the kind with 0 tabs). Repros back to at least 52171d2da <details> <summary>Attempted bisect</summary> * ❌ 2e3d5e658 (HEAD -> main, origin/main) Rewrite AtlasEngine to allow arbitrary overhangs * ❔ 405fb5120 Fix AppInitialized latency metric * ❔ e413a4148 Prevent crash when VTParameters::subspan is out of range * ❔ 4ebc383cb A hypothetical fix for hidden windows * ❔ fea6eeddf Disable the context menu command inside a zipped folder * ❔ adbe4a0d0 Fix missing call to UpdateViewport::UpdateViewport during tearout * ❔ 7e9f09f49 A very sensible Pane refactoring * ❔ 06dc975a0 Switch to function pointers * ❔ def3742a2 Fix focus issue when profile selected from nested menu entry * ❔ 5ed3c76dc Remove IsUwp, RunAsUwp, defaults-universal and all fallout * ❔ e491141bd Remove the window thread from the list of threads before nulling the AppHost * ❔ 0d1540bbd Add buttons for selecting commands, output to context menu * ❔ 2cfd73d81 Enable WINRT_LEAN_AND_MEAN * ❔ ee0530737 Also do the VisualState dance on the tab item * ❔ 478834756 Make sure the command palette isn't null * ❔ 210414e5a (origin/1.17) Default to XamlRoot when unable to find focused object * ❔ 2aefb3035 Remove a 1px gap under the tabs only visible at >150% * ❔ ffda8c4a9 Add automation heading level 1 to fix about dialog * ❔ 2fd33ba51 unpackaged: allow building an unpackaged distribution from layout * ❔ 2c165438e Add a warning when a proportional font is selected * ❔ 0e86ce559 Add the ability to select a whole command (or its output) * ❔ 35b9e7557 Avoid animations during startup * ❔ da0a6d468 Lazy load CommandPalette and AboutDialog * ❔ c2dd6143a Fix Peasant::ActivateWindow being called with an all 0 GUID * ❔ 27bcf7e41 Add subtext to why Always show tabs is not toggleable in SUI. * ❔ 2c16e7c07 Respect the startup info state initially passed to `wt` via ShellExecute * ❔ 1825ca104 fix not updating the nav view when add/removing profiles * ❔ e106c095a Enable ctrl+shift to run terminal elevated from context menu * ❌ 52171d2da Update to MUX 2.8.3 * ❔ 9b960bc88 Fix reordering tabs mysteriously shuffling the actual backing tabs * ❔ 1d354d0f5 Fix a hang when writing wide glyphs into a 1 column terminal * ❔ eb725e999 fix: WpfTerminalControl allow Connection set to null * ❔ 19069e03b A more efficient copy assignment operator for Pane.LayoutSizeNode * ❔ (👀) 21464fe41 Manually hide our DesktopWindowXamlSource * ❌ 789b0b065 Actually use the persisted position with `centerOnLaunch:true` * ❔ 72d0566fa (dev/migrie/b/mux-2.8.l3) Back off between attempts to start the tests * ❔ f671f065b Register the GetWindowLayoutRequested handler only when ready * ❔ 10bdadffb Skip generating a profile for rancher-desktop * ❔ 56d451ded Support environment variables in the settings * ❔ 508adbb1e Send a KeyUp sequence only once a key has been released * ❔ b4f65030e Fix re-persisting the new legacy themes * ❔ 90bbd2927 Helix: Decode HTML entities in the test comment fiel * ❔ ea44375f6 Check for updates automatically (but don't install) * ❔ 7fbd3be8c Only try to hand off to ConhostV1 if building for Windows * ❔ de09671d8 wpf: Bump the history length to 9001 instead of 1000 * ❔ c7498a426 PGO: Update the Helix payload to rely on the unpackaged distribution * ❔ 083fc647b Revert the revert of "Hide the window until we're finished with initialization" * ❔ 6f8ef5867 Add support for running the Terminal without _any_ windows * ❔ fe66ba5f5 Add "legacy" themes * ❔ e73362d45 Respect the codepage stored in .LNK files in conhost * ❔ a98a0cf2c Stop the beef when you hover off a hyperlink * ❔ 5db8af627 Return success if ReadCharacterInput read >0 characters * ❔ 5f7092049 When unpackaged, isolate the monarch by the install path * ❌ 62448969b Upgrade clang-format to 15.0.7 * ❔ ecb5e37a7 Use new row primitives for ResizeTraditional * ❔ aea0477bd Filter out control characters that don't do anything * ❔ 06526cac0 Remove our dependency on any CRT--AppX or forwarders * ❔ 9dfdf2afa Introduce til::linear_flat_set * ❔ 2a839d8c5 Fix accuracy bugs around float/double/int conversions * ❔ da995a014 Enable holding ctrl to open the Terminal elevated from Fil * ❔ 47a17cf2d Replace statics in headers with inline constants * ❔ c0f14567f Use DIPs for the window bounds when tearing out * ❔ 5de1fd9a7 Introduce til::generational - a struct comparison helper * ❔ 17cf44fa7 Upgrade to MUX 2.8 * ❔ 06174a9cb Format URLs for display when we show the tooltip * ❔ 0656afcf1 Expose hyperlink attributes in PaintBufferGridLines * ❔ 0d38d1729 Add a simple tool to test rendering functionality * ❔ 7ddd98de0 Fix warnings in til for an upcoming version of MSVC * ❔ 0105807be Add pre-build PowerShell version check * ❔ e6a3fa8d4 Add "portable mode", where settings load from the install path * ❔ bbd4d1b1e Fix a crash in the rclick context menu * ❔ 984b03ca3 [SPEC] Add a lightweight spec for Portable Mode * ❔ 7b0aca444 Enable tearing out tabs to create new windows * ❔ dd63a0590 Add support for an unpackaged distribution of Terminal * ❔ fc9580253 Merge the LineFeed functionality into AdaptDispatch * ❔ da3a33f3b Minor cleanups after #14745 * ❔ 9514c1191 Enable dragging tabs between windows * ❔ 17a5b7733 Add support for moving panes and tabs between windows * ❔ 34aa6aa0d Update DECSC/DECRC to match the newer DEC terminals * ❔ c7816fdb0 Add flexible virtualization rules for HKCU\Console\Startup * ❔ d9efdae98 Fix font size of HTML clipboard contents * ❔ c4d029829 Add a second way of detecting whether DefTerm is available * ❌ f20cd3a9d Add an efficient text stream write function * ❔ f5e9e8ea7 Consolidate our MSIX distribution back down to one package </details> OKAY I think this has got to be something unique to my machine.
claunia added the Needs-Tag-FixProduct-TerminalSeverity-BlockingArea-DefApp labels 2026-01-31 06:53:01 +00:00
claunia commented 2026-01-31 06:53:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 26, 2023):

Guys I can't explain it, but I

  • closed all terminal instances (dev, preview and stable)
  • did a del /s *openconsoleproxy.*
  • re-deployed the Terminal

and it's working again. Sorry for the fire drill 🙃

@zadjii-msft commented on GitHub (Apr 26, 2023): Guys I can't explain it, but I * closed all terminal instances (dev, preview and stable) * did a `del /s *openconsoleproxy.*` * re-deployed the Terminal and it's working again. Sorry for the fire drill 🙃
claunia commented 2026-01-31 06:53:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 26, 2023):

Or, more correctly, it explodes whenever I'm debugging with VS? Whatever.

@zadjii-msft commented on GitHub (Apr 26, 2023): Or, more correctly, it explodes whenever I'm debugging with VS? Whatever.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19766
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?