Commit Graph

2577 Commits

Author SHA1 Message Date
root
265d99095b Fix three BLAKE2sp correctness bugs and eliminate allocations in hot path
1. Fix off-by-one in Update(BLAKE2SP): pos was masked with 448 (64×7)
   instead of 511 (64×8−1), causing incorrect leaf assignment when update
   chunks are not multiples of 64 bytes. This produced wrong hashes
   whenever streaming reads didn't align to 64-byte boundaries.

2. Fix double-finalization when Read() is called again after returning 0.
   Final() was called unconditionally on each EOF read, re-running
   compression on an already-finalized state and corrupting the hash.
   EnsureHash() guards with a null-check and is idempotent; both sync
   and async Read paths share the fix. _blake2sp is set to null after
   finalization so any erroneous post-final calls fail fast rather than
   silently corrupting state.

3. Fix false-positive CRC check when stream is not fully drained.
   _hash was initialized to fileHeader.FileCrc in the constructor, so
   GetCrc() returned the expected CRC rather than the computed one if
   the stream was abandoned early. The check would then compare the
   expected hash against itself and always succeed, silently accepting
   a corrupt or incomplete file. _hash is now null until the stream is
   fully read; GetCrc() throws if called early rather than returning a
   misleading value.

Additional changes:
- Compress: stackalloc m/v arrays instead of heap; LE fast path via
  MemoryMarshal.Cast replaces 16 BitConverter.ToUInt32 calls per block
- Final(BLAKE2S): write directly to Span<byte>, eliminating MemoryStream
  and BitConverter.GetBytes allocations; 8 leaf digests now stackalloc'd
- Inner classes and fields: private, sealed, readonly where applicable
2026-03-27 13:34:00 -04:00
Adam Hathcock
b54c42028c Merge pull request #1243 from adamhathcock/adam/api-clean-up
Some API clean up from GPT 5.4
2026-03-10 16:45:29 +00:00
Adam Hathcock
b05a16d007 oops, wrong change made 2026-03-06 15:39:07 +00:00
Adam Hathcock
e6a179bdb5 fmt 2026-03-06 15:33:57 +00:00
Adam Hathcock
f13ab3a0e7 FindFactoryAsync shouldn't be public 2026-03-06 15:33:30 +00:00
Adam Hathcock
ebd784cfb2 code review changes 2026-03-06 15:16:28 +00:00
Adam Hathcock
15d6d3c641 Merge remote-tracking branch 'origin/master' into adam/api-clean-up 2026-03-06 15:12:56 +00:00
Adam Hathcock
542f71f0de Merge pull request #1244 from adamhathcock/copilot/sub-pr-1243
Rename IWriteableArchiveFactory.cs to IWritableArchiveFactory.cs
2026-03-06 15:07:36 +00:00
Adam Hathcock
c6e2221b24 Merge pull request #1245 from adamhathcock/adam/clean-up-tests
Proper test file clean up
2026-03-06 15:07:08 +00:00
Adam Hathcock
04d1a10114 don't use static scratch directory for tests. Throw exception when test can't clean up 2026-03-06 14:58:04 +00:00
copilot-swe-agent[bot]
b0e9736005 Rename IWriteableArchiveFactory.cs to IWritableArchiveFactory.cs to match interface name
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-03-06 14:52:06 +00:00
copilot-swe-agent[bot]
bf32c85933 Initial plan 2026-03-06 14:48:55 +00:00
Adam Hathcock
9050a7a64a remove extra creates 2026-03-06 11:43:44 +00:00
Adam Hathcock
f34ed8bd94 first commit for conslidating publci api 2026-03-06 11:22:09 +00:00
Adam Hathcock
b719edfa57 Merge pull request #1242 from adamhathcock/adam/update-deps
Update test dependencies
0.47.0
2026-03-03 17:29:30 +00:00
Adam Hathcock
7c0e3d584a Update test dependencies 2026-03-03 17:01:21 +00:00
Adam Hathcock
5a8119e562 Merge remote-tracking branch 'origin/release'
# Conflicts:
#	src/SharpCompress/Common/Zip/ZipFilePart.cs
#	src/SharpCompress/IO/SharpCompressStream.cs
2026-03-03 16:25:10 +00:00
Adam Hathcock
1d07f4e1ca Merge pull request #1237 from adamhathcock/copilot/fix-zip-extraction-error
Fix DataErrorException when extracting LZMA-compressed zero-byte ZIP entries
2026-03-03 16:21:11 +00:00
Adam Hathcock
3abf0dc3f3 Merge pull request #1239 from adamhathcock/adam/extractionoptions-are-back
Moving extraction options back
2026-03-03 16:19:27 +00:00
Adam Hathcock
3fb7e02653 update docs 2026-03-03 12:50:27 +00:00
Adam Hathcock
0910f20c90 renamed to ReaderOptions.ForFilePath 2026-03-03 12:40:58 +00:00
Adam Hathcock
8fbb2688d9 Merge pull request #1240 from adamhathcock/dependabot/github_actions/actions/upload-artifact-7
Bump actions/upload-artifact from 6 to 7
2026-03-02 14:05:15 +00:00
dependabot[bot]
d17b74e608 Bump actions/upload-artifact from 6 to 7
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v6...v7)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-03-02 10:23:07 +00:00
Adam Hathcock
ba1cd66336 First pass of moving extraction options back 2026-03-02 07:00:33 +00:00
Adam Hathcock
10b6e903c1 Merge pull request #1238 from adamhathcock/adam/fix-zip-extraction-error
Fix DataErrorException when extracting LZMA-compressed zero-byte ZIP entries
0.46.4
2026-03-01 13:55:44 +00:00
Adam Hathcock
4445b8e01e fmt 2026-03-01 13:38:20 +00:00
Adam Hathcock
fc426c73e0 correct fix 2026-03-01 13:37:48 +00:00
copilot-swe-agent[bot]
c1b132c215 Fix DataErrorException when extracting 0-size LZMA ZIP entries
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

# Conflicts:
#	src/SharpCompress/Common/Zip/ZipFilePart.Async.cs
#	src/SharpCompress/Common/Zip/ZipFilePart.cs
2026-03-01 13:25:54 +00:00
copilot-swe-agent[bot]
30dfa72622 Fix DataErrorException when extracting LZMA-compressed zero-byte ZIP entries
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-02-27 22:10:58 +00:00
copilot-swe-agent[bot]
75d2b70f20 Fix DataErrorException when extracting 0-size LZMA ZIP entries
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-02-27 22:06:18 +00:00
copilot-swe-agent[bot]
55c2e75b1d Initial plan 2026-02-27 21:49:40 +00:00
Adam Hathcock
6e8ae5d342 Merge pull request #1235 from adamhathcock/adam/support-async-7z-writing 2026-02-25 18:31:29 +00:00
Adam Hathcock
50e8c66c27 Add async 7z writing 2026-02-25 16:39:22 +00:00
Adam Hathcock
c4acf1774d Merge pull request #1233 from adamhathcock/adam/expose-sc-stream
Make SharpCompressStream public
0.46.3
2026-02-25 14:16:34 +00:00
Adam Hathcock
28319f1510 Merge pull request #1234 from adamhathcock/copilot/sub-pr-1233
Fix SharpCompressStream.Create() buffer size misalignment for non-seekable streams
2026-02-25 13:13:56 +00:00
copilot-swe-agent[bot]
d0bfdfd6ab Fix buffer size alignment: use RewindableBufferSize consistently in Create() and StartRecording()
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-02-25 10:41:26 +00:00
copilot-swe-agent[bot]
5a0d6dd333 Initial plan 2026-02-25 10:38:41 +00:00
Adam Hathcock
0778b13086 add more docs 2026-02-25 09:15:40 +00:00
Adam Hathcock
a53a88b9dc Make SharpCompressStream public 2026-02-25 09:10:21 +00:00
Adam Hathcock
852a077085 Merge pull request #1229 from DanNsk/feature/sevenzip-writer-lzma2-new 2026-02-24 18:15:40 +00:00
Adam Hathcock
543c33e26b fmt 2026-02-24 17:09:32 +00:00
Daniil Bystrukhin
9c214a658c Rewind output stream when non-seekable empty input leaves orphaned encoder bytes 2026-02-22 23:31:41 -06:00
Daniil Bystrukhin
d512655c5c Adapt SevenZipFactory and WriterOptionsExtensions to upstream IWriterFactory changes 2026-02-22 23:12:33 -06:00
D. B.
3e35d7e6b4 Merge branch 'adamhathcock:master' into feature/sevenzip-writer-lzma2-new 2026-02-22 23:02:09 -06:00
Daniil Bystrukhin
2093ceb700 Merge feature/sevenzip-writer-lzma review fixes into lzma2 branch 2026-02-22 22:57:12 -06:00
Daniil Bystrukhin
02fa306b46 Fix empty stream handling, SubStreamsInfo size tag, CRC dedup, and post-dispose guard 2026-02-22 22:54:09 -06:00
Daniil Bystrukhin
d4277f5907 Code review fixes: post-dispose guard, SubStreamsInfo spec compliance, CRC dedup, exception filter 2026-02-22 22:30:47 -06:00
Daniil Bystrukhin
d82cf8f911 Merge feature/sevenzip-writer-lzma - use CompressionType enum, default LZMA2 2026-02-22 21:19:13 -06:00
Daniil Bystrukhin
97b8a93a0c Pass CompressionType through compressor instead of bool isLzma2 2026-02-22 21:15:17 -06:00
Daniil Bystrukhin
bcf628568c Replace IsLzma2 flag with CompressionType enum for 7z writer API consistency 2026-02-22 21:08:34 -06:00